[Maps] refactor filter actions to use embeddable actions #41713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
💔 Build Failed |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
thomasneirynck
approved these changes
Jul 23, 2019
| async getESFilters() { | ||
| const esFilters = []; | ||
| if (this._tooltipProperty.isFilterable()) { | ||
| esFilters.push(...(await this._tooltipProperty.getESFilters())); |
There was a problem hiding this comment.
this is really dense.
consider using multi-line.
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jul 23, 2019
* [Maps] refactor filters to use filter actions * remove isFilterable from redux state * more removal of set filterable
nreese
added a commit
that referenced
this pull request
Jul 24, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 24, 2019
* upstream/7.x: Ensure visualizations in percentage mode respect the advanced settings percent format (elastic#39044) (elastic#41855) [7.x] [telemetry] Analytics Package (elastic#41113) (elastic#41774) [Uptime] Improve `useUrlParams` hook for Uptime app (elastic#41545) (elastic#41818) [Maps] refactor filter actions to use embeddable actions (elastic#41713) (elastic#41821) [Maps] clean up tooltip header and footer (elastic#41793) (elastic#41816) [SIEM] Timeline NOT working with unauthorized (elastic#41767) (elastic#41873) Use index patterns service inside data plugin (rather than importing from ui/public) (elastic#41639) (elastic#41867)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
isFilterablefrom redux state and instead passes addFilters to GisMap component. addFilters uses embeddable actions in Map embeddable