[Canvas] Fixes toggle between edit mode/read only mode #41293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set height on Canvas workarea header
|
Small design PR here: cqliu1#10 |
ryankeairns
approved these changes
Jul 16, 2019
💚 Build Succeeded |
cqliu1
added
bug
|
Pinging @elastic/kibana-canvas |
This was referenced Jul 17, 2019
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Jul 17, 2019
* Fixed mergeProps in workpad_header/index.js * set header height
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Jul 17, 2019
* Fixed mergeProps in workpad_header/index.js * set header height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #39813.
This was introduced in #38832 (specifically this line https://github.com/elastic/kibana/pull/38832/files#diff-650bbe73e863a4dcf8be48d755eae887L28). It called the
setWriteableaction directly (which doesn't do anything) instead of dispatching the action to redux, so the redux state wasn't being updated.This fixes that bug and reenables the edit mode/read only mode toggle.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers