-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix migration issue with old filter queries #41245
Fix migration issue with old filter queries #41245
Conversation
…eta property have query string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
* Fix migration issue that assumes old filter queries that don't have meta property have query string * fix type error * adjust snapshot so it includes the new title attribute
* Fix migration issue that assumes old filter queries that don't have meta property have query string * fix type error * adjust snapshot so it includes the new title attribute
This is not fixed on 7.3.0 snapshot from july 23rd. I get the same error. CC @marius-dr |
Very interesting. https://github.com/elastic/kibana/pull/41269/files was merged into 7.3, and it actually changed the error message slightly...
to give more information than the original error message:
I will checkout 7.3 branch and import the file to test. |
Summary
The code assumed that having a query property and not a
meta
property meant it was in a specific format (had aquery_string
property). This is not always the case.fixes #41240
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately