Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EUI 12.3.1 #41061

Merged
merged 8 commits into from
Jul 15, 2019
Merged

EUI 12.3.1 #41061

merged 8 commits into from
Jul 15, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented Jul 12, 2019 •
edited
Loading

Summary

Fixes #32399

12.3.1

Bug fixes

  • Restored missing scss and react-datepicker files to the npm-published packaged (#2119)

12.3.0

Note: this release contained a change which prevented necessary files from being published to npm, this was fixed in 12.3.1

  • Added logoSecurity, logoCode, logoMaps, logoUptime and logoLogging to EuiIcon types (#2111)
  • Added a column direction option to EuiFlexGrid (#2073)
  • Updated EuiSuperDatePicker's commonly used date/times to display as columns. (#2073)
  • Added TypeScript definition for EuiFormControlLayout (#2086)
  • Changed SASS mixin euiOverflowShadow() to use mask-image instead of box-shadow (#2088)
  • Added SASS mixin and CSS utility euiYScrollWithShadows (#2088)
  • Added display prop to EuiPopover (#2112)

Bug fixes

  • Widened EuiComboBox's options[].value / EuiComboBoxOptionProps.value TypeScript definition (#2080)
  • Added TS defs for EuiComboBox's props spreading onto a div (#2080)
  • Fixed responsive display of inline EuiDatePicker (#1820)
  • Removed time from default dateFormat of EuiDatePicker (#1820)
  • Fixed EuiPopover from catching and preventing propagation of keydown events when closed (#2089)
  • Fixed padding sizes between EuiModal header, body, and footer (#2088)
  • Fixed placeholder text color for more browsers (#2113)

Deprecations

  • Removed logoXpackfrom EuiIcon types (#2111)

@snide snide added the release_note:skip Skip the PR/issue when compiling release notes label Jul 12, 2019
@snide snide requested review from a team as code owners July 12, 2019 22:19
@snide
Copy link
Contributor Author

snide commented Jul 12, 2019

Maintainers. Updates are just to snapshots due to non-breaking EUI updates.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide snide requested review from a team as code owners July 14, 2019 21:33
@chandlerprall
Copy link
Contributor

@snide I resolved the TS issues, also updated x-pack/legacy/plugins/maps/public/connected_components/layer_panel/_layer_panel.scss which was passing an argument to euiOverflowShadow

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor Author

snide commented Jul 15, 2019

@chandlerprall Thanks. Adjusted one more as well. 🤞

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@snide
Copy link
Contributor Author

snide commented Jul 15, 2019

@chandlerprall feel free to merge on approval.

@snide
Copy link
Contributor Author

snide commented Jul 15, 2019

Adjusted the logos on the homepage now that we have the icons.

image

@elasticmachine
Copy link
Contributor

💔 Build Failed

peteharverson
peteharverson approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to ML snapshots LGTM

legrego
legrego approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security/spaces changes LGTM

thompsongl
thompsongl approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM

weltenwort
weltenwort approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra plugin change LGTM

@cchaos cchaos mentioned this pull request Jul 15, 2019
Closed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

cqliu1
cqliu1 approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@cqliu1 cqliu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chandlerprall chandlerprall merged commit 76fb809 into elastic:master Jul 15, 2019
@chandlerprall
Copy link
Contributor

I'll set up the 7.x backport @snide

@chandlerprall chandlerprall mentioned this pull request Jul 15, 2019
Merged
chandlerprall pushed a commit to chandlerprall/kibana that referenced this pull request Jul 15, 2019
@snide @chandlerprall
EUI 12.3.1 (elastic#41061)
2a008bb 
* eui 12.3.1

* add data logos

* Fix TS uses, one SCSS use of euiOverflowShadow

* fix overflow shadow mixin in sass

* homepage logos

* refix typo on homepage

* hp snaps
@snide snide deleted the eui/12.3.1 branch July 15, 2019 18:31
chandlerprall added a commit that referenced this pull request Jul 15, 2019
@chandlerprall
EUI 12.3.1 (#41061) (#41164)
b9bb2e6 
* eui 12.3.1

* add data logos

* Fix TS uses, one SCSS use of euiOverflowShadow

* fix overflow shadow mixin in sass

* homepage logos

* refix typo on homepage

* hp snaps
@timroes
Copy link
Contributor

timroes commented Jul 18, 2019

This PR is missing some version numbers :-) Could you please still add the version numbers so one can more easily see directly in which versions this EUI update happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@legrego legrego legrego approved these changes

@thompsongl thompsongl thompsongl approved these changes

@cqliu1 cqliu1 cqliu1 approved these changes

@weltenwort weltenwort weltenwort approved these changes

@chandlerprall chandlerprall Awaiting requested review from chandlerprall

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Solution icons for Kibana Home
9 participants
@snide @elasticmachine @chandlerprall @timroes @weltenwort @cqliu1 @thompsongl @legrego @peteharverson