[ML] Adds Preview table tab to Data Frames list expanded row #39983
Conversation
alvarezmelissa87
added
release_note:enhancement
:ml
v8.0.0
v7.3.0
Feature:Transforms
|
Pinging @elastic/ml-ui |
alvarezmelissa87
force-pushed
the
ml-data-frames-preview-tab
branch
from
0c2d424 to
a1a659f
Compare
💔 Build Failed |
...egacy/plugins/ml/public/data_frame/pages/job_management/components/job_list/expanded_row.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| import { DataFramePreviewRequest } from '../../../../common'; | ||
|
|
||
| interface Transform { |
There was a problem hiding this comment.
On latest master you should be able to use DataFrameTransform from ml/public/data_frame/common/job.ts.
...egacy/plugins/ml/public/data_frame/pages/job_management/components/job_list/preview_pane.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| async function getPreview() { | ||
| try { | ||
| const transformData: any = await ml.dataFrame.getDataFrameTransforms(transformId); |
There was a problem hiding this comment.
Maybe we can pass on the transform config as a prop and don't need to fetch it again? It's available as .config on the DataFrameJobListRow objects.
...egacy/plugins/ml/public/data_frame/pages/job_management/components/job_list/preview_pane.tsx
Outdated
Show resolved
Hide resolved
|
Is it possible to format the date type columns in the Preview table, as happens inside the wizard?
|
|
@peteharverson This is a regression of the removal of automatic date formatting in the wizard done in this PR #39811. Once we do the second part of #39250 we can have human readable dates in the preview table, so this needs to be done in a follow up. |
|
The headers in the new Preview table (and also in the table inside the wizard) are hyperlinks, which implies sorting functionality, but when I click on them nothing happens. Can sorting be added in? If not, the columns should be set marked as not |
...egacy/plugins/ml/public/data_frame/pages/job_management/components/job_list/preview_pane.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
…#39983) * create preview tab in DF list expanded row * add route for fetching transform data * sort table columns. fix types * update snapshot * update tab label * add refresh functionality * pass transformConfig as prop instead of fetching
…#40132) * create preview tab in DF list expanded row * add route for fetching transform data * sort table columns. fix types * update snapshot * update tab label * add refresh functionality * pass transformConfig as prop instead of fetching
Summary
Adds
Preview tabletab to Data Frame jobs list expanded row.Note:
Currently, there is a bit a duplication (like the sorting function). The goal is to have the same component used to display the preview table here and in the wizard. For now, I've kept them separate (as refactoring will be required) and copied a bit of what I've needed.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Documentation was added for features that require explanation or tutorialsFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately