Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused table_info directive #39978

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Jun 30, 2019

Summary

Delete unused table_info directive

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

@lizozom lizozom added release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v8.0.0 Team:AppArch v7.3.0 labels Jun 30, 2019
@lizozom lizozom requested review from lukeelmers and streamich June 30, 2019 12:26
@lizozom lizozom self-assigned this Jun 30, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@stacey-gammon stacey-gammon mentioned this pull request Jun 30, 2019
94 tasks
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@@ -1,6 +0,0 @@
<div class="kuiPanel kuiPanel--centered kuiPanel--withToolBar">
<div
class="kuiTableInfo"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen this kuiTableInfo class name in a couple of more places, I wonder where does it come from.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the old design we had before EUI

@lizozom lizozom merged commit 2181e6e into elastic:master Jul 1, 2019
lizozom pushed a commit to lizozom/kibana that referenced this pull request Jul 1, 2019
lizozom pushed a commit that referenced this pull request Jul 1, 2019
@lizozom lizozom added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. labels Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.3.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants