[ML] Data frames: Updated progress reporting. #39920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
release_note:enhancement
:ml
v8.0.0
v7.3.0
Feature:Transforms
walterra
requested review from
alvarezmelissa87,
peteharverson and
jgowdyelastic
|
Pinging @elastic/ml-ui |
x-pack/legacy/plugins/ml/public/data_frame/components/job_create/job_create_form.tsx
Show resolved
Hide resolved
💚 Build Succeeded |
💚 Build Succeeded |
peteharverson
approved these changes
Jul 1, 2019
|
Created #40000 for the timestamp formatting 😛 |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Jul 1, 2019
- Adds a column mode to the data frame transforms list to indicate if the transform is batch or continuous. - For continuous data frames an animated horizontal loading indicator is shown in the Progress column instead of a progress bar with percentage. - In expanded rows, for Job details the section checkpointing was added. - In the transform wizard's creation step, for continuous transforms the progress bar is not shown. In a follow up we could add more useful stats there, like what's shown in the transform list's job details.
walterra
added a commit
that referenced
this pull request
Jul 1, 2019
- Adds a column mode to the data frame transforms list to indicate if the transform is batch or continuous. - For continuous data frames an animated horizontal loading indicator is shown in the Progress column instead of a progress bar with percentage. - In expanded rows, for Job details the section checkpointing was added. - In the transform wizard's creation step, for continuous transforms the progress bar is not shown. In a follow up we could add more useful stats there, like what's shown in the transform list's job details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
modeto the data frame transforms list to indicate if the transform isbatchorcontinuous.continuousdata frames an animated horizontal loading indicator is shown in theProgresscolumn instead of a progress bar with percentage.Job detailsthe sectioncheckpointingwas added.continuoustransforms the progress bar is not shown. In a follow up we could add more useful stats there, like what's shown in the transform list's job details.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.