Changes x-pack action executor to return result. #39820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the result was never captured. It's now captured, and
returned if it's JSONable. If not JSONable a `{succcess: true}`
object is returned with a 200 response (used to be 204).
Also added logging for action execution calls, in lieu of having an
action history available.
Drive-by:
- `services.log` was set to the unbound Hapi server.log method, so
places where it was set were changed to bind it to the server.
pmuellr
added
Feature:Alerting
release_note:skip
|
Pinging @elastic/kibana-stack-services |
|
jenkins retest this please |
💔 Build Failed |
|
jenkins retest this please |
💚 Build Succeeded |
💚 Build Succeeded |
bmcconaghy
approved these changes
Jul 1, 2019
|
|
||
| if (error != null) { | ||
| services.log( | ||
| ['info', 'x-pack', 'actions'], |
There was a problem hiding this comment.
info seems like the wrong log level for an error.
There was a problem hiding this comment.
Ah, yes. And for the info one below (success), wondering if that should be a debug. How chatty is the Kibana log? Seems usually quiet to me.
There was a problem hiding this comment.
Yeah debug is probably better for the one below.
💚 Build Succeeded |
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Jul 1, 2019
* Changes x-pack action executor to return result.
Previously, the result was never captured. It's now captured, and
returned if it's JSONable. If not JSONable a `{succcess: true}`
object is returned with a 200 response (used to be 204).
Also added logging for action execution calls, in lieu of having an
action history available.
Drive-by:
- `services.log` was set to the unbound Hapi server.log method, so
places where it was set were changed to bind it to the server.
pmuellr
added a commit
that referenced
this pull request
Jul 1, 2019
* Changes x-pack action executor to return result.
Previously, the result was never captured. It's now captured, and
returned if it's JSONable. If not JSONable a `{succcess: true}`
object is returned with a 200 response (used to be 204).
Also added logging for action execution calls, in lieu of having an
action history available.
Drive-by:
- `services.log` was set to the unbound Hapi server.log method, so
places where it was set were changed to bind it to the server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the result was never captured. It's now captured, and
returned if it's JSONable. If not JSONable a
{succcess: true}object is returned with a 200 response (used to be 204).
Also added logging for action execution calls, in lieu of having an
action history available.
Drive-by:
services.logwas set to the unbound Hapi server.log method, soplaces where it was set were changed to bind it to the server.