Graph - move custom views out of top_nav #39706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizozom
added
the
release_note:skip
💔 Build Failed |
ryankeairns
reviewed
Jun 26, 2019
ryankeairns
approved these changes
Jun 26, 2019
|
retest |
💚 Build Succeeded |
💚 Build Succeeded |
lizozom
added
Team:Visualizations
|
Pinging @elastic/kibana-app |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Jun 27, 2019
* Stop using template feature of kbn top nav * Combined css
lizozom
pushed a commit
that referenced
this pull request
Jun 29, 2019
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of the task of moving kbn_top_nav to new platform.
To do so, I wanted to narrow the functionality of
kbn_top_nav, and specifically, stop using it for rendering inline custom views.This PR focuses on the Graph app. No de-angularization is done here. Just minimal changes to stop using the
templateoption while preserving behavior. All menus should behave the same as before.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers