Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Apply dateHistogramInterval utility #39665

Merged
merged 4 commits into from
Jul 5, 2019
Merged

[TSVB] Apply dateHistogramInterval utility #39665

merged 4 commits into from
Jul 5, 2019

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jun 26, 2019 •
edited
Loading

Summary

Apply the dateHistogramInterval utility for TSVB, which can be used to calculate the correct interval key (calendar_interval or fixed_interval) for a given interval string (like 10s, 1h, etc.).

More details you can find here: #39091

Checklist

For maintainers

@alexwizp alexwizp added Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@polyfractal polyfractal mentioned this pull request Jun 26, 2019
Closed
4 tasks
@alexwizp alexwizp added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Jun 26, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexwizp alexwizp marked this pull request as ready for review June 26, 2019 11:00
@alexwizp alexwizp requested review from a team, timroes, markov00 and gospodarsky June 26, 2019 11:00
@alexwizp
Copy link
Contributor Author

retest

@elastic elastic deleted a comment from elasticmachine Jun 27, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes
Copy link
Contributor

timroes commented Jul 1, 2019

It seems we're currently not validating the interval entered into the field (correctly). You currently can enter 2w which will then be passed intodateHistogramInterval which will throw an error, thus leaving the user with an "No data to display for the selected metrics" screen instead a visualization. We should also change the UI to use the isValidEsInterval to check an interval (besides auto) if it's valid otherwise mark it as an error and not send the request.

@alexwizp alexwizp force-pushed the tsvb_dateHistogramInterval branch from 2edf54e to 4d6bca2 Compare July 2, 2019 13:39
@alexwizp alexwizp requested a review from timroes July 2, 2019 13:40
@elasticmachine
Copy link
Contributor

💔 Build Failed

@spalger spalger added the v7.4.0 label Jul 3, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@timroes timroes removed the v7.3.0 label Jul 4, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

timroes
timroes approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Chrome Linux, Code LGTM

vitalics
vitalics approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@vitalics vitalics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexwizp alexwizp merged commit 10cbd3c into elastic:master Jul 5, 2019
@alexwizp alexwizp mentioned this pull request Jul 5, 2019
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jul 5, 2019
@alexwizp
[TSVB] Apply dateHistogramInterval utility (elastic#39665)
f5be987 
* [TSVB] Apply dateHistogramInterval utility

* isModelValid -> isModelInvalid
@alexwizp alexwizp mentioned this pull request Jul 5, 2019
Closed
2 tasks
alexwizp added a commit that referenced this pull request Jul 6, 2019
@alexwizp
[TSVB] Apply dateHistogramInterval utility (#39665) (#40410)
2a10374 
* [TSVB] Apply dateHistogramInterval utility

* isModelValid -> isModelInvalid
@timroes timroes mentioned this pull request Oct 9, 2019
Closed
@alexwizp alexwizp deleted the tsvb_dateHistogramInterval branch January 4, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitalics vitalics vitalics approved these changes

@timroes timroes timroes approved these changes

@markov00 markov00 Awaiting requested review from markov00

@gospodarsky gospodarsky Awaiting requested review from gospodarsky

Assignees
No one assigned
Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexwizp @elasticmachine @timroes @vitalics @spalger