Adds a slack action #39221
Merged
Adds a slack action #39221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
pmuellr
added
Feature:Alerting
release_note:skip
|
Pinging @elastic/kibana-stack-services |
pmuellr
force-pushed
the
alerting/slack-action-2
branch
from
7be1efc to
ecdc4b4
Compare
pmuellr
commented
Jun 19, 2019
💚 Build Succeeded |
mikecote
reviewed
Jun 20, 2019
bmcconaghy
approved these changes
Jun 21, 2019
x-pack/test/api_integration/apis/actions/builtin_action_types/slack.ts
Outdated
Show resolved
Hide resolved
pmuellr
force-pushed
the
alerting/slack-action-2
branch
from
ecdc4b4 to
4797237
Compare
|
Just forced push this branch to get the code up to the new x-pack/legacy/plugin level. Let's see how CI goes; once green, will un-draft ... |
💚 Build Succeeded |
mikecote
reviewed
Jun 24, 2019
| */ | ||
|
|
||
| // a function which returns a promise with a resolve() and reject() method | ||
| export function rPromise() { |
There was a problem hiding this comment.
I am unable to find where this function is used?
There was a problem hiding this comment.
ah yes, it appears to be unused now, will delete
x-pack/legacy/plugins/actions/server/builtin_action_types/slack.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/actions/server/builtin_action_types/slack.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/actions/server/builtin_action_types/slack.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/actions/server/builtin_action_types/slack.ts
Outdated
Show resolved
Hide resolved
| let actionTypeRegistry: ActionTypeRegistry; | ||
| let actionType: ActionType; | ||
|
|
||
| const mockEncryptedSavedObjectsPlugin = { |
There was a problem hiding this comment.
I created a new mock that we can now re-use x-pack/legacy/plugins/encrypted_saved_objects/server/plugin.mock.ts.
💔 Build Failed |
pmuellr
commented
Jun 24, 2019
package.json
Outdated
| @@ -119,6 +119,7 @@ | |||
| "@kbn/pm": "1.0.0", | |||
| "@kbn/test-subj-selector": "0.2.1", | |||
| "@kbn/ui-framework": "1.0.0", | |||
| "@slack/webhook": "^5.0.0", | |||
There was a problem hiding this comment.
this should be in x-package/package.json, not the root package.json
💔 Build Failed |
- move @slack/webhook from package.json to x-pack/package.json - remove unused r_promise module - refactor the way slack mock works - rename id of slack action from `kibana.slack` to `.slack`
💚 Build Succeeded |
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Jun 25, 2019
pmuellr
added a commit
that referenced
this pull request
Jun 25, 2019
Closed
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Slack action to the nascent Actions sub-framework that's part of the nascent Alerting framework.