Allow users to disable polling in Console #38949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
release_note:enhancement
Feature:Console
|
Pinging @elastic/es-ui |
💔 Build Failed |
- Add button for manually refreshing the suggestions. - Change buttons to use the EUI classes.
cjcenizal
force-pushed
the
console/turn-off-polling
branch
from
71e055e to
4282795
Compare
💔 Build Failed |
|
Retest |
💔 Build Failed |
alisonelizabeth
approved these changes
Jun 18, 2019
|
|
||
| // Retrieve autocomplete info if the user has changed one of the autocomplete settings or | ||
| // has turned on polling. | ||
| if (settingsDiff.length > 0 || getPolling()) { |
There was a problem hiding this comment.
I'm not sure the || getPolling() is necessary. I think it's only going to refetch the autocomplete settings if any of them have changed (i.e., if settingsDiff.length > 0). So if the user only turns on polling, it will be a no-op.
There was a problem hiding this comment.
Good catch! I forgot to address this before merging, so I'll fix it in #39114.
|
CC @jbudz |
💚 Build Succeeded |
cjcenizal
added a commit
that referenced
this pull request
Jun 19, 2019
5 tasks
This was referenced Jun 22, 2019
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13052 and #36278, and replaces #32132.
Release note
By default, Console polls Elasticsearch to retrieve the latest mappings, aliases, etc to populate its autocomplete suggestions. This can cause performance problems for users with large clusters and pose a challenge for users with bandwidth constraints. This features addresses these issues by allowing users to disable this polling behavior. It also adds a button that the user can click to refresh the autocomplete suggestions manually.