Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] UI Dark theme fixes #38840

Merged
merged 5 commits into from
Jun 14, 2019
Merged

[APM] UI Dark theme fixes #38840

merged 5 commits into from
Jun 14, 2019

Conversation

formgeist
Copy link
Contributor

Summary

Making some minor theming tweaks to APM UI, especially around the Transaction detail and Timeline view.

Screenshot 2019-06-12 at 22 43 45

  • Removed the hard-coded background color from the Timeline axis element
  • Changed the Timeline axis text color to match the other charts' style
  • Updated the borderRadius variable to match the Eui styling

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@formgeist formgeist added WIP Work in progress Team:APM All issues that need APM UI Team support labels Jun 12, 2019
@formgeist formgeist requested a review from a team as a code owner June 12, 2019 20:44
@formgeist formgeist self-assigned this Jun 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

dgieselaar
dgieselaar approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@formgeist formgeist changed the title [APM] UI Dark theme fixes (WIP) [APM] UI Dark theme fixes Jun 14, 2019
@formgeist formgeist removed the WIP Work in progress label Jun 14, 2019
@formgeist
Copy link
Contributor Author

@dgieselaar Still some way to go for us to fully have especially the charts and Timeline visualization fully dark themeable, but I think that work is pretty much documented in #30048 and #29725. I'll go ahead and merges these fixes for now.

@formgeist formgeist mentioned this pull request Jun 14, 2019
Closed
14 tasks
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@formgeist formgeist merged commit 68eb968 into elastic:master Jun 14, 2019
@formgeist formgeist mentioned this pull request Jun 14, 2019
Merged
formgeist added a commit that referenced this pull request Jun 14, 2019
@formgeist
[APM] UI Dark theme fixes (#38840) (#38968)
6bbe81f 
* Removed hard-coded background color

* Updated x-axis ticks text color to match other charts

* Updated to match Eui border-radius

* Update snapshots
@formgeist formgeist deleted the dark-theme-fixes branch June 14, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees

@formgeist formgeist

Labels
release_note:enhancement Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@formgeist @elasticmachine @dgieselaar