[Vis: Default editor] EUIficate date_ranges param editor #38647

sulemanof · 2019-06-11T11:10:16Z

Summary

Part of #30922.
Fix #38867.
EUIfication of date_ranges control for Date Range aggregation.

The PR includes:

removal of directives - validate-date-math and documentation-href;
removal of test suits for validate-date-math directive;
added test suits for DateRangesParamEditor component, which includes validation tests (previously based in validate-date-math);

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

…ranges

elasticmachine · 2019-06-11T11:14:02Z

Pinging @elastic/kibana-app

elasticmachine · 2019-06-11T12:07:52Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

src/legacy/ui/public/agg_types/controls/date_ranges.tsx

cchaos · 2019-06-11T17:52:01Z

Are blank ones valid? It's behaving that way, but it seems to me they shouldnt?

…ranges

sulemanof · 2019-06-12T15:15:47Z

Are blank ones valid? It's behaving that way, but it seems to me they shouldnt?

The behavior was not changed, also valid in previous versions:

If I'm not wrong, the empty values request means any existing date. Maybe it is a great opportunity to think about placeholders for empty inputs - e.x. earlier -> later - (such as was proposed in Ranges aggregation - #36558)

cchaos · 2019-06-12T15:57:42Z

Maybe it is a great opportunity to think about placeholders for empty inputs

Yes please! Please work with whoever you need to to accomplish this.

elasticmachine · 2019-06-12T16:39:14Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…ranges

elasticmachine · 2019-06-19T09:45:02Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

maryia-lapata

LGTM, tested locally on Chrome, Mac.

…ate_ranges

elasticmachine · 2019-06-20T15:10:41Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

cchaos

LGTM with one word change.

src/legacy/ui/public/agg_types/controls/date_ranges.tsx

flash1293

LGTM with one suggestion but nothing important:
On narrow screens the config UI takes up the whole width which means there is enough space for the two date inputs to be shown beside each other (by adding the responsive prop: <EuiFlexGroup responsive={false} gutterSize="s" alignItems="center">).

IMHO it looks better that way because the date ranges don't tend to get that long

vs

What do you think, @cchaos ?

…ranges

sulemanof · 2019-06-21T08:31:38Z

IMHO it looks better that way because the date ranges don't tend to get that long

@flash1293 good finding, thanks! 👍

Maybe you have an info of how many people using kibana on narrow screens? (I'm just curious, seems it is not really convenient on mobile devices)

elasticmachine · 2019-06-21T09:30:01Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

flash1293 · 2019-06-21T09:44:23Z

Maybe you have an info of how many people using kibana on narrow screens? (I'm just curious, seems it is not really convenient on mobile devices)

@sulemanof I don't :) Looking at dashboards is probably a common use case, editing visualizations not so much I would expect. I was more thinking about people having small browser windows because they show multiple kibana tabs at once

sulemanof · 2019-06-21T11:09:26Z

retest

cchaos · 2019-06-21T11:40:29Z

Yes, good catch @flash1293 !

While we don't officially say that Visualize is mobile-friendly, we try to ensure the layout isn't completely broken. So I agree that it should add the responsive={false} prop. Eventually, we'll get to a place where our apps are more mobile-friendly.

elasticmachine · 2019-06-21T12:14:28Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

sulemanof · 2019-06-21T13:02:53Z

retest

elasticmachine · 2019-06-21T14:04:11Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-21T15:38:39Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…ranges

elasticmachine · 2019-06-24T09:02:23Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* EUIficate date_ranges param editor * Add unit tests * Move link before the list * Add validation * Fix comments # Conflicts: # src/legacy/ui/public/agg_types/controls/date_ranges.html

)" This reverts commit f39a027.

* EUIficate date_ranges param editor * Add unit tests * Move link before the list * Add validation * Fix comments # Conflicts: # src/legacy/ui/public/agg_types/controls/date_ranges.html

…9505) * EUIficate date_ranges param editor * Add unit tests * Move link before the list * Add validation * Fix comments # Conflicts: # src/legacy/ui/public/agg_types/controls/date_ranges.html

sulemanof added 3 commits June 11, 2019 12:07

EUIficate date_ranges param editor

f3688b1

Add unit tests

43160cd

Merge remote-tracking branch 'upstream/master' into EUIfication/date_…

ea25c94

…ranges

sulemanof added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Vis Editor Visualization editor issues release_note:skip Skip the PR/issue when compiling release notes v7.3.0 v8.0.0 labels Jun 11, 2019

sulemanof requested review from cchaos and maryia-lapata June 11, 2019 11:14

cchaos suggested changes Jun 11, 2019

View reviewed changes

Merge remote-tracking branch 'upstream/master' into EUIfication/date_…

27acfa2

…ranges

timroes mentioned this pull request Jun 12, 2019

EUIficate vis editor data panel #30922

Closed

29 tasks

Move link before the list

d823f48

sulemanof requested review from wylieconlon, flash1293 and chrisdavies June 12, 2019 15:41

sulemanof mentioned this pull request Jun 13, 2019

Add warning for empty values in a Date Range aggregation #38867

Closed

sulemanof added 2 commits June 18, 2019 12:21

Merge remote-tracking branch 'upstream/master' into EUIfication/date_…

89e1234

…ranges

Add validation

81461a5

sulemanof force-pushed the EUIfication/date_ranges branch from 778abf6 to 81461a5 Compare June 19, 2019 08:49

sulemanof requested a review from cchaos June 19, 2019 08:52

maryia-lapata approved these changes Jun 20, 2019

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into EUIfication/d…

b19e562

…ate_ranges

cchaos approved these changes Jun 20, 2019

View reviewed changes

src/legacy/ui/public/agg_types/controls/date_ranges.tsx Outdated Show resolved Hide resolved

flash1293 approved these changes Jun 21, 2019

View reviewed changes

sulemanof added 2 commits June 21, 2019 11:22

Fix comments

b8e31d2

Merge remote-tracking branch 'upstream/master' into EUIfication/date_…

0d663e4

…ranges

Merge remote-tracking branch 'upstream/master' into EUIfication/date_…

629f5db

…ranges

sulemanof force-pushed the EUIfication/date_ranges branch from 406a4b3 to 629f5db Compare June 24, 2019 07:58

sulemanof merged commit 3184be1 into elastic:master Jun 24, 2019

sulemanof deleted the EUIfication/date_ranges branch June 24, 2019 09:13

sulemanof added a commit that referenced this pull request Jun 24, 2019

Revert "[Vis: Default editor] EUIficate date_ranges param editor (#38647

4db5e65

)" This reverts commit f39a027.

sulemanof mentioned this pull request Jun 24, 2019

[7.x] [Vis: Default editor] EUIficate date_ranges param editor (#38647) #39505

Merged

sulemanof added the backported label Jun 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Vis: Default editor] EUIficate date_ranges param editor #38647

[Vis: Default editor] EUIficate date_ranges param editor #38647

sulemanof commented Jun 11, 2019 •

edited

Loading

elasticmachine commented Jun 11, 2019

elasticmachine commented Jun 11, 2019

cchaos commented Jun 11, 2019

sulemanof commented Jun 12, 2019

cchaos commented Jun 12, 2019

elasticmachine commented Jun 12, 2019

elasticmachine commented Jun 19, 2019

maryia-lapata left a comment

elasticmachine commented Jun 20, 2019

cchaos left a comment

flash1293 left a comment

sulemanof commented Jun 21, 2019

elasticmachine commented Jun 21, 2019

flash1293 commented Jun 21, 2019

sulemanof commented Jun 21, 2019

cchaos commented Jun 21, 2019

elasticmachine commented Jun 21, 2019

sulemanof commented Jun 21, 2019

elasticmachine commented Jun 21, 2019

elasticmachine commented Jun 21, 2019

elasticmachine commented Jun 24, 2019

[Vis: Default editor] EUIficate date_ranges param editor #38647

[Vis: Default editor] EUIficate date_ranges param editor #38647

Conversation

sulemanof commented Jun 11, 2019 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Jun 11, 2019

elasticmachine commented Jun 11, 2019

💚 Build Succeeded

cchaos commented Jun 11, 2019

sulemanof commented Jun 12, 2019

cchaos commented Jun 12, 2019

elasticmachine commented Jun 12, 2019

💚 Build Succeeded

elasticmachine commented Jun 19, 2019

💚 Build Succeeded

maryia-lapata left a comment

Choose a reason for hiding this comment

elasticmachine commented Jun 20, 2019

💚 Build Succeeded

cchaos left a comment

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

sulemanof commented Jun 21, 2019

elasticmachine commented Jun 21, 2019

💔 Build Failed

flash1293 commented Jun 21, 2019

sulemanof commented Jun 21, 2019

cchaos commented Jun 21, 2019

elasticmachine commented Jun 21, 2019

💔 Build Failed

sulemanof commented Jun 21, 2019

elasticmachine commented Jun 21, 2019

💔 Build Failed

elasticmachine commented Jun 21, 2019

💔 Build Failed

elasticmachine commented Jun 24, 2019

💚 Build Succeeded

sulemanof commented Jun 11, 2019 •

edited

Loading