Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security - Reorder Saved Objects Client wrappers #38444

Closed
wants to merge 50 commits into from
Closed

Security - Reorder Saved Objects Client wrappers #38444

wants to merge 50 commits into from

Commits on Jun 6, 2019

  1. convert SecureSavedObjectsClientWrapper to TypeScript

    @legrego
    legrego committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    c7acf55 View commit details
    Browse the repository at this point in the history

  2. change spaces soc wrapper order. allow space id to be set on the request

    @legrego
    legrego committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    7a410c7 View commit details
    Browse the repository at this point in the history

  3. change security soc wrapper order. Extract privilege checking

    @legrego
    legrego committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    e23adc0 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2019

  1. Merge branch 'master' of github.com:elastic/kibana into reorder-soc-w… 

    …rappers
    @legrego
    legrego committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    4b97e2c View commit details
    Browse the repository at this point in the history

  2. add namespace tests for SOC wrapper

    @legrego
    legrego committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    30d0641 View commit details
    Browse the repository at this point in the history

  3. testing checkSavedObjectsPrivileges

    @legrego
    legrego committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    6f06c67 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:elastic/kibana into reorder-soc-w… 

    …rappers
    @legrego
    legrego committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    764322c View commit details
    Browse the repository at this point in the history

  5. revert changes to spaces saved objects client wrapper

    @legrego
    legrego committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    c98c1cd View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2019

  1. cleanup

    @legrego
    legrego committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    2c95f6c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:elastic/kibana into reorder-soc-w… 

    …rappers
    @legrego
    legrego committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    0b4a769 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2019

  1. SOC Reordering nitpicks (#20) 

    * Using SavedObjectsClientContract['errors'] instead of any for errors

* Moving security's SOC wrapper to authorization/saved_objects

* Renaming 'action' to operation

* Renaming checkSavedObjectsPrivileges to ensureSavedObjectsPrivileges

We use "check" elsewhere when returning a "check privileges result", and
we use "ensure" elsewhere when an Error will be thrown if the user
doesn't have any privileges.

* Adding "general error" tests for ensure saved object privileges

* Removing general error tests from wrapper

* Change the SecureSavedObjectsClientWrapper tests to be strictly white-box
    @kobelb @legrego
    kobelb authored and legrego committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    93d01cb View commit details
    Browse the repository at this point in the history

  2. revert changes to spaces service

    @legrego
    legrego committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    dfff4ab View commit details
    Browse the repository at this point in the history

  3. Revert "revert changes to spaces saved objects client wrapper" 

    This reverts commit c98c1cd.
    @legrego
    legrego committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    b2c5884 View commit details
    Browse the repository at this point in the history

  4. testing namespace passing

    @legrego
    legrego committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    d66cfae View commit details
    Browse the repository at this point in the history

  5. Merge branch 'reorder-soc-wrappers' of github.com:legrego/kibana into… 

    … reorder-soc-wrappers
    @legrego
    legrego committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    5bf4ea6 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' of github.com:elastic/kibana into reorder-soc-w… 

    …rappers
    @legrego
    legrego committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    5a8e987 View commit details
    Browse the repository at this point in the history

  7. assert checkPrivilegesWithRequest is called with the incoming request

    @legrego
    legrego committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    3096d56 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2019

  1. exploring a 'classed' namespace 

    fixing deleteByNamespace

fixing encrypted saved objects api tests
    @legrego
    legrego committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    1be8f53 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2019

  1. Merge branch 'master' of github.com:elastic/kibana into reorder-soc-w… 

    …rappers
    @legrego
    legrego committed Jun 17, 2019
    Configuration menu
    Copy the full SHA
    b09c26e View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2019

  1. Merge branch 'master' of github.com:elastic/kibana into reorder-soc-w… 

    …rappers
    @legrego
    legrego committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    f601e42 View commit details
    Browse the repository at this point in the history

  2. rename Namespace => SavedObjectsNamespace, fixing merge from master a… 

    …long the way
    @legrego
    legrego committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    9f80cf4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:elastic/kibana into reorder-soc-w… 

    …rappers
    @legrego
    legrego committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    61b203d View commit details
    Browse the repository at this point in the history

  4. saved objects service test updates

    @legrego
    legrego committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    5854319 View commit details
    Browse the repository at this point in the history

  5. update deleteByNamespace

    @legrego
    legrego committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    1e481ab View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2019

  1. Merge branch 'master' of github.com:elastic/kibana into reorder-soc-w… 

    …rappers
    @legrego
    legrego committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    c0fa8cc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:elastic/kibana into reorder-soc-w… 

    …rappers
    @legrego
    legrego committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    591153a View commit details
    Browse the repository at this point in the history

  3. introducing DEFAULT_SPACE_NAMESPACE symbol

    @legrego
    legrego committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    7209f43 View commit details
    Browse the repository at this point in the history

  4. additional tests

    @legrego
    legrego committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    bc06c38 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2019

  1. revert exposing SavedObjectsRepository

    @legrego
    legrego committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    9ab8289 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:elastic/kibana into reorder-soc-w… 

    …rappers
    @legrego
    legrego committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    f6f6803 View commit details
    Browse the repository at this point in the history

  3. fix doc warning

    @legrego
    legrego committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    f18e865 View commit details
    Browse the repository at this point in the history

  4. fix build

    @legrego
    legrego committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    cb0d974 View commit details
    Browse the repository at this point in the history

  5. use relative imports for SavedObjectsNamespace

    @legrego
    legrego committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    348ef98 View commit details
    Browse the repository at this point in the history

  6. assert that the repository cannot accept Symbol namespaces

    @legrego
    legrego committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    8353f0f View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' of github.com:elastic/kibana into reorder-soc-w… 

    …rappers
    @legrego
    legrego committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    fd91f37 View commit details
    Browse the repository at this point in the history

  8. updating api docs

    @legrego
    legrego committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    739cd86 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' of github.com:elastic/kibana into reorder-soc-w… 

    …rappers
    @legrego
    legrego committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    0e40f5b View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' of github.com:elastic/kibana into reorder-soc-w… 

    …rappers
    @legrego
    legrego committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    f46e46b View commit details
    Browse the repository at this point in the history

  11. readd snapshots

    @legrego
    legrego committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    968d8f8 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2019

  1. Revert "use relative imports for SavedObjectsNamespace" 

    This reverts commit 348ef98.
    @legrego
    legrego committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    e2796ff View commit details
    Browse the repository at this point in the history

  2. Revert "assert that the repository cannot accept Symbol namespaces" 

    This reverts commit 8353f0f.
    @legrego
    legrego committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    7c6bbfd View commit details
    Browse the repository at this point in the history

  3. Revert "updating api docs" 

    This reverts commit 739cd86.
    @legrego
    legrego committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    cada7ea View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:elastic/kibana into reorder-soc-w… 

    …rappers
    @legrego
    legrego committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    016479d View commit details
    Browse the repository at this point in the history

  5. assert that the repository cannot accept Symbol namespaces

    @legrego
    legrego committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    0530155 View commit details
    Browse the repository at this point in the history

  6. update namespace assertions

    @legrego
    legrego committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    4bfeb3b View commit details
    Browse the repository at this point in the history

  7. fix typings

    @legrego
    legrego committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    d44ab61 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' of github.com:elastic/kibana into reorder-soc-w… 

    …rappers
    @legrego
    legrego committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    ba8d21f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. Merge branch 'master' of github.com:elastic/kibana into reorder-soc-w… 

    …rappers
    @legrego
    legrego committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    fee5532 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. Merge branch 'master' of github.com:elastic/kibana into reorder-soc-w… 

    …rappers
    @legrego
    legrego committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    49956c2 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2019

  1. Merge branch 'master' of github.com:elastic/kibana into reorder-soc-w… 

    …rappers
    @legrego
    legrego committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    b5ffdac View commit details
    Browse the repository at this point in the history