[Maps] symbolize points with maki icons #37822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:enhancement
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
jenkins, test this |
💚 Build Succeeded |
💔 Build Failed |
💚 Build Succeeded |
nickpeihl
requested changes
Jun 7, 2019
There was a problem hiding this comment.
I receive an error when I attempted to change an existing grid aggregation layer from circle to icon. The error also occurs when changing an existing grid aggregation layer from icon to circle.
Error: Uncaught TypeError: Cannot read property 'queryRadius' of undefined (webpack://%5Bname%5D/./node_modules/mapbox-gl/dist/mapbox-gl.js?:28)
Document layers look great and are very performant!
💔 Build Failed |
💚 Build Succeeded |
kindsun
reviewed
Jun 12, 2019
x-pack/plugins/maps/public/shared/layers/styles/components/vector/legend/symbol_icon.js
Show resolved
Hide resolved
kindsun
reviewed
Jun 12, 2019
x-pack/plugins/maps/public/shared/layers/styles/components/vector/legend/symbol_icon.js
Outdated
Show resolved
Hide resolved
💔 Build Failed |
kindsun
reviewed
Jun 14, 2019
x-pack/plugins/maps/public/shared/layers/styles/symbol_utils.js
Outdated
Show resolved
Hide resolved
|
Wow that is a cool feature! lgtm with green CI!
|
kindsun
approved these changes
Jun 14, 2019
💔 Build Failed |
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jun 14, 2019
* [Maps] sybmolize points with maki icons * add from for selecting symbol * add from for selecting symbol * get icons working for static colors * static icon sizing * refacto symbol_utils * timing issue * use SDF icons * dynamic iconSize * set icon-anchor * display symbol icon in map legend * add unit tests for VectorIcon * set icon fill based on dark mode * remove unused file * fix jest tests * set icon-opacity * use size style to configure icon-image small or large * fix queryRadius error by just hiding other point layer instead of removing * remove console statement on error * use maki icon size constants * add retry around opening set view popover for flaky test
nreese
added a commit
that referenced
this pull request
Jun 14, 2019
* [Maps] sybmolize points with maki icons * add from for selecting symbol * add from for selecting symbol * get icons working for static colors * static icon sizing * refacto symbol_utils * timing issue * use SDF icons * dynamic iconSize * set icon-anchor * display symbol icon in map legend * add unit tests for VectorIcon * set icon fill based on dark mode * remove unused file * fix jest tests * set icon-opacity * use size style to configure icon-image small or large * fix queryRadius error by just hiding other point layer instead of removing * remove console statement on error * use maki icon size constants * add retry around opening set view popover for flaky test
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #30738
This PR adds maki icons to the Maps application so users can sybmolize points with icons instead of circles. Don't be scared by the line count, 5600 of those are from sprite sheet json definition.