Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track tilemap event handlers and unbind at destroy #3774

Merged
merged 2 commits into from
May 7, 2015

Conversation

rashidkpc
Copy link
Contributor

Closes #3763

Tracks when events are attached to elements and unbinds them at map.destroy() time.

@lukasolson
Copy link
Member

Hmm... I get the following error when I try to create a tile map now (and nothing shows up on the map):

TypeError: Failed to execute 'removeChild' on 'Node': parameter 1 is not of type 'Node'.
at TypeError (native)
at o.Control.o.Class.extend.removeFrom (http://localhost:5601/bower_components/leaflet/dist/leaflet.js:9:11353)
at o.Map.include.removeControl (http://localhost:5601/bower_components/leaflet/dist/leaflet.js:9:11654)
at http://localhost:5601/components/vislib/visualizations/tile_map.js:638:15
at Array.forEach (native)
at TileMap.destroy (http://localhost:5601/components/vislib/visualizations/tile_map.js:637:19)
at http://localhost:5601/components/vislib/lib/handler/handler.js:206:17
at Array.forEach (native)
at Handler.destroy (http://localhost:5601/components/vislib/lib/handler/handler.js:204:19)
at Vis._runOnHandler (http://localhost:5601/components/vislib/vis.js:82:29)

@lukasolson lukasolson assigned rashidkpc and unassigned lukasolson May 7, 2015
@rashidkpc rashidkpc assigned lukasolson and unassigned rashidkpc May 7, 2015
@lukasolson
Copy link
Member

LGTM!

lukasolson added a commit that referenced this pull request May 7, 2015
Track tilemap event handlers and unbind at destroy
@lukasolson lukasolson merged commit e875c23 into elastic:master May 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error when drawing bounding box in tile map
2 participants