Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding number formatting (thousand separator with comma's) to panel.char... #377

Closed
wants to merge 5 commits into from

Conversation

jamesbrucepower
Copy link

...t == 'total'

@jamesbrucepower
Copy link
Author

Ok this probably needs more work, such as:

  • ability to choose whether the number is formatted or not via the editor
  • ability to use this style number formatting for all numbers across all panels (problem here is sorting since it becomes a string, also I have a pet hate for this having to be in the model, this should be done in the presentation layer by CSS, but its not part of CSS3, grrrrr)

But I thought someone else might want this as is, as it makes total hit counts much more readable

@cdeck
Copy link

cdeck commented Dec 10, 2013

@rashidkpc 👍 I'm constantly having to highlight counts to figure out if I'm dealing with millions or billions. Have you had a chance to evaluate this pull request yet?

@rashidkpc
Copy link
Contributor

I've not, the contributor closed the request soon after opening it. I'm open to another solution.

@tmaiaroto
Copy link

I always use a simple filter in my Angular projects, I've made a pull request: #728 ... it's based off of http://phpjs.org/functions/number_format
You could then just use it where ever I imagine.

rashidkpc pushed a commit that referenced this pull request Oct 6, 2014
harper-carroll pushed a commit to harper-carroll/kibana that referenced this pull request Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants