Convert common/lib files to Typescript and Jest #37640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crob611
added
Team:Presentation
|
Pinging @elastic/kibana-canvas |
crob611
added
v8.0.0
v7.3.0
chore
loe:medium
💚 Build Succeeded |
clintandrewhall
approved these changes
Jun 13, 2019
| * @field Name of the column that we are looking for the type of | ||
| * @returns The column type or the string 'null' | ||
| */ | ||
| export function getFieldType(columns: DatatableColumn[], field?: string) { |
There was a problem hiding this comment.
nit: add return type. It's only inferred at the moment to be string.
| >( | ||
| rows: RowType[], | ||
| columns?: string[] | ||
| ): { [s in ReturnColumns]: s extends keyof RowType ? Array<RowType[s]> : undefined[] } { |
There was a problem hiding this comment.
nit: make s a whole word variable: why not column? And do we expect an array of undefineds? I think you want never.
💚 Build Succeeded |
💚 Build Succeeded |
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Jul 1, 2019
* Remove unused lib and associated tests * Convert unquote string to TS and Jest * Convert getFieldType to TS and Jest * Convert httpurl to TS and Jest * Remove latest_change and tests * Convert pivot_object_array to TS and Jest * Address PR feedback
crob611
pushed a commit
that referenced
this pull request
Jul 1, 2019
* Convert common/lib files to Typescript and Jest (#37640) * Remove unused lib and associated tests * Convert unquote string to TS and Jest * Convert getFieldType to TS and Jest * Convert httpurl to TS and Jest * Remove latest_change and tests * Convert pivot_object_array to TS and Jest * Address PR feedback * Fix type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the first of probably many PRs to convert from Mocha to Jest tests. Since these were mainly small utilities, I went ahead and converted the files to Typescript as well.
A few of the files here (latest_change, find_in_object) were not being used, so they are being deleted.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers