-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade enzyme and enzyme-adapter-react-16 to the latest #37064
Conversation
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
/* | ||
The issue with [email protected] -> the fix has not been released yet -> https://github.com/airbnb/enzyme/pull/2027 | ||
TODO: Enable the expectation after the next patch released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This module isn't being worked on a ton right now, would you mind adding something to your calendar to return to this in a couple weeks once the enzyme-adapter is updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spalger sure.
@sulemanof is on vacation, so I will track this.
💔 Build Failed |
💚 Build Succeeded |
* Upgrade enzyme and enzyme-adapter-react-16 to the latest * Skip failed expectation * Update yarn.lock * Update snapshot
* Upgrade enzyme and enzyme-adapter-react-16 to the latest * Skip failed expectation * Update yarn.lock * Update snapshot
Summary
The main purpose of this is an ability to test React functional components with Hooks API.
The necessity of writing such tests is in scope of EUIfication of an old vis editor #30922
Checklist
For maintainers