Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vis] Move propFilter from ui/filter to ui/agg_types/filter #36875

Merged
merged 6 commits into from
May 24, 2019
Merged

[Vis] Move propFilter from ui/filter to ui/agg_types/filter #36875

merged 6 commits into from
May 24, 2019

Conversation

maryia-lapata
Copy link
Contributor

Summary

Move propFilter from ui/filter to ui/agg_types/filter

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💔 Build Failed

@maryia-lapata maryia-lapata requested review from timroes and lizozom May 22, 2019 14:30
@maryia-lapata maryia-lapata marked this pull request as ready for review May 22, 2019 14:30
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@maryia-lapata maryia-lapata mentioned this pull request May 22, 2019
Merged
7 tasks
timroes
timroes approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a small change using proper generics for the filter function so no types are lost when using it. Besides that the code lgtm if you find time and it's easy enough to convert the test to jest I would appreciate that, but otherwise it looks good to me.

src/legacy/ui/public/agg_types/__tests__/filter/prop_filter.js Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

timroes
timroes approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@maryia-lapata maryia-lapata merged commit cdd1a1d into elastic:master May 24, 2019
@maryia-lapata maryia-lapata deleted the move-prop-filter branch May 24, 2019 13:51
@maryia-lapata maryia-lapata added Feature:Vis Editor Visualization editor issues v7.3.0 labels May 24, 2019
@maryia-lapata maryia-lapata mentioned this pull request May 24, 2019
Merged
maryia-lapata added a commit to maryia-lapata/kibana that referenced this pull request May 24, 2019
@maryia-lapata
[Vis] Move propFilter from ui/filter to ui/agg_types/filter (elastic#…
54b5252 
…36875)

* Move propFilter from ui/filter to ui/agg_types/filter

* Return default value

* Make propFilter generic

* Convert propFilter from a mocha test to a jest test
maryia-lapata added a commit that referenced this pull request May 25, 2019
@maryia-lapata
[Vis] Move propFilter from ui/filter to ui/agg_types/filter (#36875) (#…
6825df6 
…37090)

* Move propFilter from ui/filter to ui/agg_types/filter

* Return default value

* Make propFilter generic

* Convert propFilter from a mocha test to a jest test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

@lizozom lizozom Awaiting requested review from lizozom

Assignees
No one assigned
Labels
backported Feature:Vis Editor Visualization editor issues v7.3.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maryia-lapata @elasticmachine @timroes