Move filter bar and apply filters to data plugin #36778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💔 Build Failed |
|
retest |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
lizozom
force-pushed
the
newplatform/data-plugin/filter-bar-5
branch
from
0cbd927 to
f18824c
Compare
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
added 4 commits
May 28, 2019 18:04
With filter_bar and ApplyFiltersPopover Update imports
lizozom
force-pushed
the
newplatform/data-plugin/filter-bar-5
branch
from
2806f39 to
04c2367
Compare
|
Pinging @elastic/kibana-app-arch |
cchaos
approved these changes
May 28, 2019
💚 Build Succeeded |
lukeelmers
approved these changes
May 28, 2019
| * under the License. | ||
| */ | ||
|
|
||
| export { FilterService, FilterSetup } from './filter_service'; |
There was a problem hiding this comment.
nit: this file could just be .ts instead of .tsx
There was a problem hiding this comment.
will fix in subsequent PR
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
May 29, 2019
* Setup filter plugin With filter_bar and ApplyFiltersPopover Update imports * Updated i18n keys * Typo fix * update JP translation names
lizozom
pushed a commit
that referenced
this pull request
May 30, 2019
* Move filter bar and apply filters to data plugin (#36778) * Setup filter plugin With filter_bar and ApplyFiltersPopover Update imports * Updated i18n keys * Typo fix * update JP translation names * Fixed i18n names * yarn lock * translations again
jkakavas
pushed a commit
to jkakavas/kibana
that referenced
this pull request
May 30, 2019
* Setup filter plugin With filter_bar and ApplyFiltersPopover Update imports * Updated i18n keys * Typo fix * update JP translation names
lizozom
added
the
release_note:skip
This was referenced Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move filter bar and apply filters UI components to the filter service of data plugin