Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license management copy related to security #36204

Merged
merged 3 commits into from
May 7, 2019

Conversation

jen-huang
Copy link
Contributor

@jen-huang jen-huang commented May 7, 2019

Fixes #36167

I confirmed with @skearns64 that advanced security is a sufficient phrase to refer to Gold+ security features.

image

image

@jen-huang jen-huang added Feature:License v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.2.0 v6.8.0 v7.1.0 labels May 7, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

Copy link
Contributor

@peterschretlen peterschretlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work!

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@yaronp68 yaronp68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterschretlen
Copy link
Contributor

peterschretlen commented May 7, 2019

@jen-huang sorry I should have caught this during review - looks like the jest snapshots need updating, that seems to be the cause of the test failures:
x-pack/plugins/license_management/__jest__/__snapshots__/request_trial_extension.test.js.snap
x-pack/plugins/license_management/__jest__/__snapshots__/revert_to_basic.test.js.snap
x-pack/plugins/license_management/__jest__/__snapshots__/start_trial.test.js.snap

Also noticed we have "like to continuing using machine learning" in the trial extension message, maybe change continuing -> continue ?

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jen-huang
Copy link
Contributor Author

Thanks for catching those @peterschretlen! I will make the changes.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:License release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v6.8.0 v7.1.0 v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update wording around license and security
6 participants