[ILM] Surface shrink action in edit form if it's already been set on the policy #35987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
Feature:ILM
v8.0.0
Team:Kibana Management
|
Pinging @elastic/es-ui |
cjcenizal
commented
May 2, 2019
| @@ -196,11 +198,14 @@ export const phaseFromES = (phase, phaseName, defaultEmptyPolicy) => { | |||
| } | |||
|
|
|||
| if (actions.shrink) { | |||
| policy[PHASE_SHRINK_ENABLED] = true; | |||
There was a problem hiding this comment.
This line contains the actual fix.
💚 Build Succeeded |
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
May 2, 2019
…the policy (elastic#35987) * Set PHASE_SHRINK_ENABLED to true if the action has been specified on the phase.
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
May 2, 2019
…the policy (elastic#35987) * Set PHASE_SHRINK_ENABLED to true if the action has been specified on the phase.
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
May 2, 2019
…the policy (elastic#35987) * Set PHASE_SHRINK_ENABLED to true if the action has been specified on the phase.
💚 Build Succeeded |
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
May 3, 2019
…the policy (elastic#35987) * Set PHASE_SHRINK_ENABLED to true if the action has been specified on the phase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35674
If you create an Index Lifecycle Policy with a "shrink" action set and attempt to edit it, the "Shrink" toggle will now accurately reflect the action being set.