Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ui/vis imports to point to plugins/visualizations. #35764

Closed
wants to merge 9 commits into from

Conversation

lukeelmers
Copy link
Member

@lukeelmers lukeelmers commented Apr 29, 2019

Do not merge yet.

Reviewers

This is a follow up to #35625 & should be reviewed after that PR is merged.

In #35625, the visualizations plugin was introduced, with services for visTypes and visFilters that re-exported from the ui/vis module.

In this PR, we are taking every import that references the ui/vis services that were moved, and updating it to import from plugins/visualizations instead of ui/vis. This will make it simpler for us to move the ui/vis module behind the scenes, and will also allow some time for 3rd party vis developers to update their plugin imports.

Prior to merging, I'll update the dev docs issue with notes on these changes.

QA

This introduces no functional changes.

Dev Docs

This requires a dev docs entry, but rather than adding the notes here, I am combining them with the existing dev docs issue.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lukeelmers
Copy link
Member Author

Closing as our conventions for handling shimmed imports have changed since this exploration was started, and also because we will first try to move the code and re-export from ui/public to prevent needing to make all of these import updates right away.

This work will gradually be replaced in subsequent PRs, beginning with #43730

@lukeelmers lukeelmers closed this Aug 22, 2019
@lukeelmers lukeelmers deleted the feat/vis-imports branch February 11, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants