-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ui/vis imports to point to plugins/visualizations. #35764
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeelmers
added
Feature:New Platform
v8.0.0
:AppArch
release_note:skip
Skip the PR/issue when compiling release notes
v7.2.0
labels
Apr 29, 2019
Pinging @elastic/kibana-app-arch |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
This was referenced Jun 10, 2019
Closing as our conventions for handling shimmed imports have changed since this exploration was started, and also because we will first try to move the code and re-export from This work will gradually be replaced in subsequent PRs, beginning with #43730 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge yet.
Reviewers
This is a follow up to #35625 & should be reviewed after that PR is merged.
In #35625, the
visualizations
plugin was introduced, with services forvisTypes
andvisFilters
that re-exported from theui/vis
module.In this PR, we are taking every import that references the
ui/vis
services that were moved, and updating it to import fromplugins/visualizations
instead ofui/vis
. This will make it simpler for us to move theui/vis
module behind the scenes, and will also allow some time for 3rd party vis developers to update their plugin imports.Prior to merging, I'll update the dev docs issue with notes on these changes.
QA
This introduces no functional changes.
Dev Docs
This requires a dev docs entry, but rather than adding the notes here, I am combining them with the existing dev docs issue.