Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Storybook start script to build_sass #34511

Closed
wants to merge 1 commit into from
Closed

[chore] Storybook start script to build_sass #34511

wants to merge 1 commit into from

Conversation

clintandrewhall
Copy link
Contributor

Summary

This switches the Storybook start script from running a full Kibana server instance to simply building the necessary SASS files before starting, using @spalger's new script from #34323.

@clintandrewhall clintandrewhall added review chore Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0 v7.2.0 labels Apr 4, 2019
@clintandrewhall clintandrewhall requested a review from spalger April 4, 2019 00:08
@clintandrewhall clintandrewhall requested a review from a team as a code owner April 4, 2019 00:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

spalger
spalger approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clintandrewhall
Copy link
Contributor Author

This was superseded by #34757

@clintandrewhall clintandrewhall deleted the storybook-script branch April 15, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
chore review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clintandrewhall @elasticmachine @spalger