Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vis: Default editor] EUIficate regex control #33935

Conversation

maryia-lapata
Copy link
Contributor

@maryia-lapata maryia-lapata commented Mar 27, 2019

Summary

I started migration of regex control for aggregation parameter and noticed that that control is used in Significant Terms aggregation only. And the request fails with 400 status code when that field is defined.

On the screenshot below you can see that Significant Terms aggregation with a pattern fails with 400 code whereas Terms aggregation with a pattern is run well, though the doc says that filtering values functionality in Significant Terms is the same as in Terms.

Mar-29-2019 11-16-44

Significant Terms request fails with the reason: Unknown parameter in Include/Exclude clause: pattern. The request body was:

image

Terms request is succeeded. The request body was:

image

As you may note the include field has the different types: Significant Terms sends an object and fails because of unknown parameter in Include, Terms sends a string. I guess that the API was changed and Significant Terms config wasn't undated.

Since the Include/Exclude pattern configuration of Significant Terms should be the same as for Terms, I changed the model structure for Significant Terms's pattern parameters: include: { pattern: '*' } -> include: '*'.

Part of #30922

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@maryia-lapata maryia-lapata requested a review from timroes March 29, 2019 09:02
@timroes
Copy link
Contributor

timroes commented Mar 29, 2019

Closing this in favor of moving the significant terms include/exclude over to a string (see #33263). Sorry for the unnecessary work :-(

@timroes timroes closed this Mar 29, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@maryia-lapata maryia-lapata deleted the vis-editor-param-regex-control branch October 21, 2019 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants