-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vis: Default editor] EUIficate regex control #33935
Closed
maryia-lapata
wants to merge
21
commits into
elastic:master
from
maryia-lapata:vis-editor-param-regex-control
Closed
[Vis: Default editor] EUIficate regex control #33935
maryia-lapata
wants to merge
21
commits into
elastic:master
from
maryia-lapata:vis-editor-param-regex-control
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
Closing this in favor of moving the significant terms include/exclude over to a string (see #33263). Sorry for the unnecessary work :-( |
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I started migration of
regex
control for aggregation parameter and noticed that that control is used inSignificant Terms
aggregation only. And the request fails with 400 status code when that field is defined.On the screenshot below you can see that
Significant Terms
aggregation with a pattern fails with 400 code whereasTerms
aggregation with a pattern is run well, though the doc says that filtering values functionality inSignificant Terms
is the same as inTerms
.Significant Terms
request fails with the reason:Unknown parameter in Include/Exclude clause: pattern
. The request body was:Terms
request is succeeded. The request body was:As you may note the
include
field has the different types:Significant Terms
sends an object and fails because of unknown parameter in Include,Terms
sends a string. I guess that the API was changed andSignificant Terms
config wasn't undated.Since the Include/Exclude pattern configuration of
Significant Terms
should be the same as forTerms
, I changed the model structure forSignificant Terms
's pattern parameters:include: { pattern: '*' }
->include: '*'
.Part of #30922