Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[es] ignore version qualifiers in production #33877

Merged
merged 2 commits into from
Apr 17, 2019

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Mar 26, 2019

Currently there isn't a way for us to check the version qualifier from the _nodes endpoint. Pending elastic/elasticsearch#36859, we remove this check'

Closes #31347

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylersmalley
Copy link
Contributor

Do you think this needs backported to 7.0.1?

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jbudz
Copy link
Member Author

jbudz commented Mar 26, 2019

Hm, I'm not sure that we need it at all if we're skipping 7.0.0-*. Ideally upstream es would have support for qualifiers by then. Thoughts on closing?

@jbudz jbudz added the non-issue Indicates to automation that a pull request should not appear in the release notes label Mar 27, 2019
@tylersmalley
Copy link
Contributor

Let's move forward with this and backport to 7.x/7.1

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jbudz jbudz merged commit 8639cec into elastic:master Apr 17, 2019
jbudz added a commit that referenced this pull request Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-issue Indicates to automation that a pull request should not appear in the release notes review Team:Operations Team label for Operations Team v7.0.1 v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong warning when starting Kibana 7.0.0-beta1
3 participants