[Logs UI] Use react-intl FormattedRelative instead of a custom component #33146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
added
v8.0.0
Feature:Logs UI
|
Pinging @elastic/infrastructure-ui |
💚 Build Succeeded |
weltenwort
changed the title
Kerry350
approved these changes
Mar 18, 2019
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Mar 18, 2019
…ent (elastic#33146) This replaces the custom relative time component in the Logs UI live streaming inline loading indicator with the one from `react-intl`. This was not done at the time of the initial i18n introduction (elastic#25213), because of elastic#26237, which apparently has since been resolved via elastic#26468. Visual changes should be limited to `now` being shown instead of `0s ago`.
weltenwort
added
the
non-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This replaces the custom relative time component in the Logs UI live streaming inline loading indicator with the one from
react-intl. This was not done at the time of the initial i18n introduction (#25213), because of #26237, which apparently has since been resolved via #26468. Visual changes should be limited tonowbeing shown instead of0s ago.Checklist
Documentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately