[Vis: Default editor] EUIficate raw json control #32888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
maryia-lapata
commented
Mar 20, 2019
| @@ -161,7 +161,6 @@ | |||
| "common.ui.aggTypes.ipRanges.toLabel": "到", | |||
| "common.ui.aggTypes.ipRanges.useCidrMasksButtonLabel": "使用 CIDR 掩码", | |||
| "common.ui.aggTypes.ipRanges.useFromToButtonLabel": "使用“从”/“到”", | |||
| "common.ui.aggTypes.jsonInputLabel": "JSON 输入", | |||
There was a problem hiding this comment.
I removed this label because sentence case was applied: JSON Input -> JSON input
|
Since |
29 tasks
maryia-lapata
changed the title
This comment has been minimized.
This comment has been minimized.
maryia-lapata
added
review
Feature:Vis Editor
cchaos
suggested changes
Mar 20, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cchaos
approved these changes
Mar 21, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
spalger
previously requested changes
Mar 25, 2019
src/legacy/ui/public/vis/editors/default/__tests__/utils.test.tsx
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
timroes
approved these changes
Mar 28, 2019
maryia-lapata
added a commit
to maryia-lapata/kibana
that referenced
this pull request
Mar 28, 2019
* EUIficate raw json control * Remove unused validate-json directive * Update tests * Update styles * Move validation logic down to control * Fix type
maryia-lapata
added a commit
that referenced
this pull request
Mar 28, 2019
maryia-lapata
added
backported
release_note:skip
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EUIfication of
jsoncontrol for aggregation parameter in Default Editor, Data tab.Tooltip:
Part of #30922
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Documentation was added for features that require explanation or tutorialsFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately