Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for embedded_visualize_handler #32657

Merged

Conversation

lukeelmers
Copy link
Member

@lukeelmers lukeelmers commented Mar 7, 2019

New PR, rebased on master to replace #31324.

The old PR caused issues on master since the last build before this got merged was a bit outdated.

@elasticmachine

This comment has been minimized.

@lukeelmers lukeelmers requested a review from ppisljar March 8, 2019 18:44
@lukeelmers lukeelmers added v7.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.2.0 labels Mar 8, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukeelmers
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants