-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for embedded_visualize_handler #32657
Merged
lukeelmers
merged 2 commits into
elastic:master
from
lukeelmers:fix/embedded-visualize-handler-tests
Mar 11, 2019
Merged
Add unit tests for embedded_visualize_handler #32657
lukeelmers
merged 2 commits into
elastic:master
from
lukeelmers:fix/embedded-visualize-handler-tests
Mar 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 7, 2019
This comment has been minimized.
This comment has been minimized.
lukeelmers
added
v7.0.0
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v8.0.0
v7.2.0
labels
Mar 8, 2019
Pinging @elastic/kibana-app |
💚 Build Succeeded |
ppisljar
approved these changes
Mar 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
retest |
💚 Build Succeeded |
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Mar 11, 2019
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Mar 11, 2019
lukeelmers
added a commit
that referenced
this pull request
Mar 11, 2019
lukeelmers
added a commit
that referenced
this pull request
Mar 11, 2019
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR, rebased on master to replace #31324.
The old PR caused issues on master since the last build before this got merged was a bit outdated.