Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Add first draft of uptime docs #31814

Merged
merged 14 commits into from
Mar 22, 2019

Conversation

justinkambic
Copy link
Contributor

@justinkambic justinkambic commented Feb 22, 2019

Summary

Add docs for Uptime user manual.

This is WIP.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@justinkambic justinkambic added Team:Docs v7.0.0 v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v6.7.0 labels Feb 22, 2019
@justinkambic justinkambic self-assigned this Feb 22, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime

@elasticmachine
Copy link
Contributor

💔 Build Failed

@bmorelli25 bmorelli25 self-requested a review February 26, 2019 19:19
@justinkambic justinkambic marked this pull request as ready for review February 26, 2019 21:36
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome start @justinkambic !

To get this to build, you'll need to add a line to Kibana's /docs/index.asciidoc file to include the new documentation. Here's what that looks like: include::uptime/index.asciidoc[]. Once you do that, you'll be able to use the build command:

// GIT_HOME="/<fullPathTYourRepos>
$GIT_HOME/docs/build_docs.pl --doc $GIT_HOME/kibana/docs/index.x.asciidoc --chunk 1 --open

That produces around 100 build errors. No problem though, they're easy fixes! I've made the changes for you in my branch. Here's the diff. I've done three things:

  1. Included the index file in the Kibana index file (like above) so the docs build
  2. Added float tags to headings. Float tags tell Asciidoc that what follows isn't a "real" header and not to break it out onto its own page
  3. Changed the IDs to be unique. IDs are the text between double square brackets: [[id-here]]. These are for linking purposes.

Once that's taken care of, see my comments below. Most of these are grammatical changes. Some are tough to decipher without the screenshots, so I'll take another look once those are ready. Note that these are suggestions. You don't have to implement everything I suggest - let's chat if you disagree!

The other thing I want to chat with you about at some point is: Why? I think this PR does a very good job of explaining the "how" and the "what" - How do I do this, what does this do, etc.. If we can work some why in as well, this'll be 🔥- Why would the snapshot view be useful, why is the status bar helpful, etc.. Sometimes this can be easily done with examples. It might make sense for us to jump on a call at some point and have you walk me through the UI. I can ask questions, and we can turn some of your answers into docs

docs/uptime/index.asciidoc Show resolved Hide resolved
docs/uptime/index.asciidoc Outdated Show resolved Hide resolved
docs/uptime/overview.asciidoc Outdated Show resolved Hide resolved
docs/uptime/overview.asciidoc Outdated Show resolved Hide resolved
docs/uptime/overview.asciidoc Outdated Show resolved Hide resolved
docs/uptime/monitor.asciidoc Outdated Show resolved Hide resolved
docs/uptime/monitor.asciidoc Outdated Show resolved Hide resolved
@andrewvc
Copy link
Contributor

andrewvc commented Mar 5, 2019

@justinkambic added security docs with 90d8883

@elasticmachine
Copy link
Contributor

💔 Build Failed

@andrewvc andrewvc mentioned this pull request Mar 7, 2019
7 tasks
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhere here we need to mention that Uptime will only work with the current major version of heartbeat. So Kibana 6.7 works with heartbeat 6.x data only.

@justinkambic
Copy link
Contributor Author

@bmorelli25 I've given some thought to your why prompt - here's my first stab at providing that: aab3a6c.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I added 9751482. Please take a look and let me know your thoughts. Happy to discuss my reasoning for any or all of the changes. Also happy to revert any of them if you have a better solution. A few notes:

  • A couple grammar fixes
  • For the most part, on the monitor and overview pages, I didn't end up changing any of the text, just moved it around a bit. A lot of moving the why to the top of the sections.
  • I added [float] tags to the security page to keep everything on one page. Also removed "ing" from the headings and moved to sentence case
  • Added // CONSOLE to the security page to provide easier copying of the snippet

docs/uptime/index.asciidoc Outdated Show resolved Hide resolved
docs/index.asciidoc Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@bmorelli25
Copy link
Member

9f469f2 - Moved the uptime docs under APM per Gail's advice.

@justinkambic - other than screenshots, still hoping to chat with you about this comment: https://github.com/elastic/kibana/pull/31814/files#r260515148

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@justinkambic
Copy link
Contributor Author

@bmorelli25 I thought I commented earlier but I can't seem to find it now. I added 7178ce3 to address your the title and content of that section.

@justinkambic
Copy link
Contributor Author

@bmorelli25 we finally added some screenshots.

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphy (1)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@justinkambic justinkambic merged commit 45d2c84 into elastic:master Mar 22, 2019
justinkambic added a commit to justinkambic/kibana that referenced this pull request Mar 22, 2019
* Add first draft of uptime docs.

* Add first draft of uptime docs.

* Implement PR feedback.

* Add role info to uptime docs

* Impelement some more PR feedback.

* Attempt to add more copy focusing on the 'why' of each piece of the docs.

* uptime docs: grammar, formatting, order

* move location of uptime docs

* Implement more PR feedback.

* Add screenshots.
justinkambic added a commit to justinkambic/kibana that referenced this pull request Mar 22, 2019
* Add first draft of uptime docs.

* Add first draft of uptime docs.

* Implement PR feedback.

* Add role info to uptime docs

* Impelement some more PR feedback.

* Attempt to add more copy focusing on the 'why' of each piece of the docs.

* uptime docs: grammar, formatting, order

* move location of uptime docs

* Implement more PR feedback.

* Add screenshots.
justinkambic added a commit that referenced this pull request Mar 22, 2019
* Add first draft of uptime docs.

* Add first draft of uptime docs.

* Implement PR feedback.

* Add role info to uptime docs

* Impelement some more PR feedback.

* Attempt to add more copy focusing on the 'why' of each piece of the docs.

* uptime docs: grammar, formatting, order

* move location of uptime docs

* Implement more PR feedback.

* Add screenshots.
justinkambic added a commit to justinkambic/kibana that referenced this pull request Mar 25, 2019
* Add first draft of uptime docs.

* Add first draft of uptime docs.

* Implement PR feedback.

* Add role info to uptime docs

* Impelement some more PR feedback.

* Attempt to add more copy focusing on the 'why' of each piece of the docs.

* uptime docs: grammar, formatting, order

* move location of uptime docs

* Implement more PR feedback.

* Add screenshots.
justinkambic added a commit that referenced this pull request Mar 25, 2019
* Add first draft of uptime docs.

* Add first draft of uptime docs.

* Implement PR feedback.

* Add role info to uptime docs

* Impelement some more PR feedback.

* Attempt to add more copy focusing on the 'why' of each piece of the docs.

* uptime docs: grammar, formatting, order

* move location of uptime docs

* Implement more PR feedback.

* Add screenshots.
justinkambic added a commit that referenced this pull request Mar 26, 2019
* [Uptime] Add first draft of uptime docs (#31814)

* Add first draft of uptime docs.

* Add first draft of uptime docs.

* Implement PR feedback.

* Add role info to uptime docs

* Impelement some more PR feedback.

* Attempt to add more copy focusing on the 'why' of each piece of the docs.

* uptime docs: grammar, formatting, order

* move location of uptime docs

* Implement more PR feedback.

* Add screenshots.

* Update snapshots.
joelgriffith pushed a commit that referenced this pull request Mar 27, 2019
* Add first draft of uptime docs.

* Add first draft of uptime docs.

* Implement PR feedback.

* Add role info to uptime docs

* Impelement some more PR feedback.

* Attempt to add more copy focusing on the 'why' of each piece of the docs.

* uptime docs: grammar, formatting, order

* move location of uptime docs

* Implement more PR feedback.

* Add screenshots.
@justinkambic justinkambic deleted the uptime_docs branch June 6, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Docs Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v6.7.0 v7.0.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants