Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design cleanup of Uptime app #31663

Merged
merged 77 commits into from
Apr 4, 2019
Merged
Show file tree
Hide file tree
Changes from 54 commits
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
9b3d911
uptime design cleanup
snide Feb 15, 2019
704cf13
uptime design cleanup
snide Feb 15, 2019
5bafda3
merge master
snide Feb 15, 2019
2d3a1f9
test
snide Feb 15, 2019
a22dcb9
errorlist now styled
snide Feb 15, 2019
e401ae8
errorlist now styled
snide Feb 15, 2019
00076a2
errorlist now styled
snide Feb 15, 2019
317d45b
Merge remote-tracking branch 'upstream/master' into d/uptime
snide Feb 20, 2019
18923de
cleanup
snide Feb 21, 2019
3a70065
Merge remote-tracking branch 'upstream/master' into d/uptime
snide Feb 21, 2019
e61fa6b
replace color vars with correct naming
snide Feb 21, 2019
36d2b4f
some titles
snide Feb 21, 2019
664a634
more cleanup
snide Feb 21, 2019
80da365
clean up silly gray graph
snide Feb 21, 2019
d6cdce4
Address problems with UI update.
justinkambic Feb 21, 2019
6b9dd4a
Refresh jest snapshots.
justinkambic Feb 21, 2019
69b57f2
Fix busted types.
justinkambic Feb 21, 2019
07417e7
Refresh jest snapshots broken by busted type fix.
justinkambic Feb 21, 2019
9edcc34
Rename duplicate localization key.
justinkambic Feb 22, 2019
4044af2
Use same curve type for both check series on monitors page.
justinkambic Feb 22, 2019
850fd96
Remove unused translations.
justinkambic Feb 22, 2019
f58b1b1
Display name instead of ID in ErrorList component.
justinkambic Feb 22, 2019
65c5651
Update x-pack/plugins/uptime/public/components/functional/ping_list.tsx
justinkambic Feb 23, 2019
b89737c
Update x-pack/plugins/uptime/public/components/functional/ping_list.tsx
justinkambic Feb 23, 2019
7e25aef
Merge master.
justinkambic Mar 8, 2019
e056995
Modify updated code to avoid flooding console log with errors.
justinkambic Mar 8, 2019
a1b4acb
Get functional and unit tests passing.
justinkambic Mar 8, 2019
60fddd4
Fix busted unit test.
justinkambic Mar 8, 2019
35bdc22
Merge master.
justinkambic Mar 12, 2019
e6bdf89
Update jest snapshots.
justinkambic Mar 12, 2019
8850330
Add panel to empty state.
justinkambic Mar 13, 2019
4617718
Avoid rendering monitor list sparkline charts when downSeries has no …
justinkambic Mar 13, 2019
73436dc
Remove crosshair synchronization from monitor charts because of displ…
justinkambic Mar 13, 2019
52789c8
Fix broken snapshot.
justinkambic Mar 13, 2019
43700a0
Update monitor list and errors list to handle simple_query_string fil…
justinkambic Mar 13, 2019
0c84947
Make FilterBar component incremental to avoid overwriting queries tha…
justinkambic Mar 13, 2019
ce4b8db
Update histogram query to support simple_text_query.
justinkambic Mar 13, 2019
3edc1e8
Delete hardcoded height prop that was breaking UI in mobile-sized win…
justinkambic Mar 13, 2019
2a0e68d
Fix bug in check histogram function and add tests.
justinkambic Mar 13, 2019
ee957cd
Merge master.
justinkambic Mar 13, 2019
09485c5
Update API tests and functional UI tests.
justinkambic Mar 13, 2019
76678e3
Fix type error in test file.
justinkambic Mar 14, 2019
37e2081
Last few fixes
cchaos Mar 14, 2019
b761442
Update snaps
cchaos Mar 14, 2019
6e168b2
WIP.
justinkambic Mar 15, 2019
0aa7ad8
Update snapshot query to avoid Apollo Query class and allow manual fe…
justinkambic Mar 15, 2019
4661071
Update SnapshotLoading component to better reflect the actual shape o…
justinkambic Mar 15, 2019
9f5036a
Introduce HOC to manage GraphQL querying.
justinkambic Mar 16, 2019
e3bb9d0
Remove unneeded code.
justinkambic Mar 17, 2019
912b247
Update monitor page query components to use new query paradigm.
justinkambic Mar 18, 2019
b99eeba
Remove remaining references to apollo query component.
justinkambic Mar 18, 2019
74773c6
Merge branch 'd/uptime' of github.com:snide/kibana into d/uptime
justinkambic Mar 18, 2019
e2e0b0e
Update filter bar snapshot.
justinkambic Mar 18, 2019
a29d7f4
Update empty state.
justinkambic Mar 18, 2019
40e6f06
Fix busted type in test.
justinkambic Mar 18, 2019
449bf52
Update schema type to avoid server error.
justinkambic Mar 18, 2019
a5d4f8e
Remove obsolete translations.
justinkambic Mar 18, 2019
01579ec
Merge branch 'master' into d/uptime
justinkambic Mar 19, 2019
3c54e20
Remove more obsolete translations.
justinkambic Mar 19, 2019
0a4e764
Merge branch 'master' into d/uptime
justinkambic Mar 26, 2019
7880029
Merge branch 'master' into d/uptime
justinkambic Mar 27, 2019
7edb0dd
Merge branch 'master' into d/uptime
justinkambic Mar 27, 2019
accc8b3
Remove obsolete code from Snapshot component. Rewrite graphql HOC wit…
justinkambic Mar 28, 2019
1f7cf7c
Change loading state condition for filter bar.
justinkambic Mar 28, 2019
a3d794a
Simplify app refresh process.
justinkambic Mar 29, 2019
b7b949d
Update loading state for several components to avoid unnecessary rend…
justinkambic Mar 29, 2019
e70c7d6
Add default sort order for getAll pings function.
justinkambic Mar 29, 2019
181a5db
Add translation to bare UI string.
justinkambic Mar 29, 2019
239f5d8
Merge master.
justinkambic Mar 29, 2019
0ac3606
Update API fixtures to handle new default sort direction.
justinkambic Apr 1, 2019
98d0ccd
Fix type errors.
justinkambic Apr 1, 2019
adde363
Merge branch 'master' into d/uptime
justinkambic Apr 3, 2019
6d3f89b
Merge branch 'master' into d/uptime
justinkambic Apr 3, 2019
3f838af
Remove unused import.
justinkambic Apr 3, 2019
687cce3
Change the way component passes children prop.
justinkambic Apr 4, 2019
d5da784
Merge branch 'master' into d/uptime
justinkambic Apr 4, 2019
9c0d0ac
Fix typing error.
justinkambic Apr 4, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -7824,10 +7824,6 @@
"xpack.upgradeAssistant.tabs.incompleteCallout.calloutBody.breackingChangesDocButtonLabel": "弃用内容和重大更改",
"xpack.upgradeAssistant.tabs.incompleteCallout.calloutBody.calloutDetail": "Elasticsearch {nextEsVersion} 中的 {breakingChangesDocButton} 完整列表将在最终的 {currentEsVersion} 次要版本中提供。完成列表后,此警告将消失。",
"xpack.upgradeAssistant.tabs.incompleteCallout.calloutTitle": "问题列表可能不完整",
"xpack.uptime.appHeader.uptimeLogoAriaLabel": "前往运行时间主页",
"xpack.uptime.appHeader.uptimeLogoText": "运行时间",
"xpack.uptime.appHeader.uptimeLogoTitle": "运行时间",
"xpack.uptime.breadcrumbs.monitorBreadcrumbText": "监测",
"xpack.uptime.breadcrumbs.overviewBreadcrumbText": "概览",
"xpack.uptime.emptyState.configureHeartbeatLinkText": "配置 Heartbeat",
"xpack.uptime.emptyState.configureHeartbeatToGetStartedMessage": "{configureHeartbeatLink} 以开始记录运行时间数据。",
Expand All @@ -7837,7 +7833,6 @@
"xpack.uptime.errorList.CountColumnLabel": "计数",
"xpack.uptime.errorList.errorMessage": "错误 {message}",
"xpack.uptime.errorList.errorTypeColumnLabel": "错误类型",
"xpack.uptime.errorList.latestErrorColumnLabel": "最新错误",
"xpack.uptime.errorList.latestMessageColumnLabel": "最新消息",
"xpack.uptime.errorList.monitorIdColumnLabel": "监测 ID",
"xpack.uptime.errorList.statusCodeColumnLabel": "状态代码",
Expand All @@ -7848,8 +7843,6 @@
"xpack.uptime.filterBar.filterUpLabel": "运行",
"xpack.uptime.filterBar.loadingMessage": "正在加载……",
"xpack.uptime.filterBar.options.portLabel": "端口",
"xpack.uptime.header.helpLinkAriaLabel": "前往我们的讨论页",
"xpack.uptime.header.helpLinkText": "讨论",
"xpack.uptime.monitorCharts.checkStatus.series.downCountLabel": "关闭计数",
"xpack.uptime.monitorCharts.checkStatus.series.upCountLabel": "运行计数",
"xpack.uptime.monitorCharts.checkStatus.title": "检查状态",
Expand All @@ -7860,14 +7853,11 @@
"xpack.uptime.monitorCharts.monitorDuration.titleLabel": "监测持续时间 (ms)",
"xpack.uptime.monitorList.downLineSeries.downLabel": "关闭",
"xpack.uptime.monitorList.errorMessage": "错误 {message}",
"xpack.uptime.monitorList.ipColumnLabel": "IP",
"xpack.uptime.monitorList.lastUpdatedColumnLabel": "最后更新时间:1/23/2016",
"xpack.uptime.monitorList.monitorHistoryColumnLabel": "监测历史记录",
"xpack.uptime.monitorList.monitoringStatusTitle": "检测状态",
"xpack.uptime.monitorList.statusColumn.downLabel": "关闭",
"xpack.uptime.monitorList.statusColumn.upLabel": "运行",
"xpack.uptime.monitorList.statusColumnLabel": "状态",
"xpack.uptime.monitorList.upLineSeries.upLabel": "运行",
"xpack.uptime.monitorStatusBar.durationTextAriaLabel": "监测持续时间(毫秒)",
"xpack.uptime.monitorStatusBar.errorMessage": "错误 {message}",
"xpack.uptime.monitorStatusBar.healthStatus.durationInMillisecondsMessage": "{duration}ms",
Expand All @@ -7881,7 +7871,6 @@
"xpack.uptime.pingList.errorMessage": "错误 {message}",
"xpack.uptime.pingList.errorMessageColumnLabel": "错误消息",
"xpack.uptime.pingList.errorTypeColumnLabel": "错误类型",
"xpack.uptime.pingList.idColumnLabel": "ID",
"xpack.uptime.pingList.ipAddressColumnLabel": "IP",
"xpack.uptime.pingList.responseCodeColumnLabel": "响应代码",
"xpack.uptime.pingList.statusColumnHealthDownLabel": "关闭",
Expand All @@ -7891,7 +7880,6 @@
"xpack.uptime.pingList.statusOptions.allStatusOptionLabel": "全部",
"xpack.uptime.pingList.statusOptions.downStatusOptionLabel": "关闭",
"xpack.uptime.pingList.statusOptions.upStatusOptionLabel": "运行",
"xpack.uptime.pingList.timestampColumnLabel": "时间戳",
"xpack.uptime.pluginDescription": "运行时间监测",
"xpack.uptime.snapshot.endpointStatusTitle": "终端节点状态",
"xpack.uptime.snapshot.errorMessage": "错误 {message}",
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/uptime/common/constants/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@

export { INDEX_NAMES } from './index_names';
export { PLUGIN } from './plugin';
export { QUERY } from './query';
24 changes: 24 additions & 0 deletions x-pack/plugins/uptime/common/constants/query.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License;
* you may not use this file except in compliance with the Elastic License.
*/

/**
* These are the fields that will be used when users enter simple_query_string
* searches into the FilterBar component.
*/
export const QUERY = {
SIMPLE_QUERY_STRING_FIELDS: [
'monitor.id',
'monitor.url',
'monitor.type',
'monitor.status',
'monitor.name',
'url.full',
'url.path',
'url.scheme',
'url.domain',
'error.type',
],
};
20 changes: 18 additions & 2 deletions x-pack/plugins/uptime/common/graphql/introspection.json
Original file line number Diff line number Diff line change
Expand Up @@ -1600,7 +1600,11 @@
"type": {
"kind": "LIST",
"name": null,
"ofType": { "kind": "OBJECT", "name": "MonitorSeriesPoint", "ofType": null }
"ofType": {
"kind": "NON_NULL",
"name": null,
"ofType": { "kind": "OBJECT", "name": "MonitorSeriesPoint", "ofType": null }
}
},
"isDeprecated": false,
"deprecationReason": null
Expand All @@ -1612,7 +1616,11 @@
"type": {
"kind": "LIST",
"name": null,
"ofType": { "kind": "OBJECT", "name": "MonitorSeriesPoint", "ofType": null }
"ofType": {
"kind": "NON_NULL",
"name": null,
"ofType": { "kind": "OBJECT", "name": "MonitorSeriesPoint", "ofType": null }
}
},
"isDeprecated": false,
"deprecationReason": null
Expand Down Expand Up @@ -2160,6 +2168,14 @@
"type": { "kind": "SCALAR", "name": "String", "ofType": null },
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "name",
"description": "",
"args": [],
"type": { "kind": "SCALAR", "name": "String", "ofType": null },
"isDeprecated": false,
"deprecationReason": null
}
],
"inputFields": null,
Expand Down
6 changes: 4 additions & 2 deletions x-pack/plugins/uptime/common/graphql/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -314,9 +314,9 @@ export interface LatestMonitor {
/** Information from the latest document. */
ping?: Ping | null;
/** Buckets of recent up count status data. */
upSeries?: (MonitorSeriesPoint | null)[] | null;
upSeries?: MonitorSeriesPoint[] | null;
/** Buckets of recent down count status data. */
downSeries?: (MonitorSeriesPoint | null)[] | null;
downSeries?: MonitorSeriesPoint[] | null;
}

export interface MonitorKey {
Expand Down Expand Up @@ -417,6 +417,8 @@ export interface ErrorListItem {
statusCode?: string | null;

timestamp?: string | null;

name?: string | null;
}

export interface MonitorPageTitle {
Expand Down
12 changes: 3 additions & 9 deletions x-pack/plugins/uptime/public/breadcrumbs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,16 @@ export interface UMBreadcrumb {
href?: string;
}

export const monitorBreadcrumb: UMBreadcrumb = {
text: i18n.translate('xpack.uptime.breadcrumbs.monitorBreadcrumbText', {
defaultMessage: 'Monitor',
}),
};

export const overviewBreadcrumb: UMBreadcrumb = {
text: i18n.translate('xpack.uptime.breadcrumbs.overviewBreadcrumbText', {
defaultMessage: 'Overview',
defaultMessage: 'Uptime',
}),
href: '#/',
};

export const getOverviewPageBreadcrumbs = (): UMBreadcrumb[] => [overviewBreadcrumb];

export const getMonitorPageBreadcrumb = (): UMBreadcrumb[] => [
export const getMonitorPageBreadcrumb = (name: string): UMBreadcrumb[] => [
overviewBreadcrumb,
monitorBreadcrumb,
{ text: name },
];

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading