configurable global socket timeouts #31603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-operations |
💔 Build Failed |
💚 Build Succeeded |
jbudz
added
the
non-issue
💚 Build Succeeded |
spalger
reviewed
May 30, 2019
eliperelman
approved these changes
May 30, 2019
spalger
approved these changes
May 30, 2019
jbudz
added
release_note:enhancement
and removed
non-issue
mshustov
reviewed
Jun 24, 2019
| server.listener.setTimeout(listenerOptions.socketTimeout); | ||
| server.listener.on('timeout', socket => { | ||
| if (socket.writable) { | ||
| socket.end(Buffer.from('HTTP/1.1 408 Request Timeout\r\n\r\n', 'ascii')); |
There was a problem hiding this comment.
adding a test for timeout shouldn't be a problem. in http_server.test.ts:
const delay = (ms: number) => new Promise(res => setTimeout(res, ms));
test('returns 408 on timeout error', async () => {
const router = new Router('');
router.get({ path: '/', validate: false }, async (req, res) => {
await delay(1000);
return res.ok({});
});
const { registerRouter, server: innerServer } = await server.setup({
...config,
socketTimeout: 1,
});
registerRouter(router);
await server.start();
await supertest(innerServer.listener).get('/').expect(408)
});
💚 Build Succeeded |
💔 Build Failed |
mshustov
approved these changes
Jul 2, 2019
|
retest |
💚 Build Succeeded |
jbudz
added a commit
that referenced
this pull request
Jul 3, 2019
* configurable global socket timeouts * update snapshots * update tests * add test * add test * add test * happy path * test happy path * docs * stop server after
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Jul 11, 2019
* configurable global socket timeouts * update snapshots * update tests * add test * add test * add test * happy path * test happy path * docs * stop server after
jbudz
added
v7.2.2
v7.3.0
release_note:fix
v6.8.2
and removed
release_note:enhancement
labels
jbudz
added a commit
that referenced
this pull request
Jul 15, 2019
* configurable global socket timeouts * update snapshots * update tests * add test * add test * add test * happy path * test happy path * docs * stop server after
jbudz
added a commit
that referenced
this pull request
Jul 15, 2019
* configurable global socket timeouts * update snapshots * update tests * add test * add test * add test * happy path * test happy path * docs * stop server after
jbudz
added a commit
that referenced
this pull request
Jul 15, 2019
* configurable global socket timeouts (#31603) * configurable global socket timeouts * update snapshots * update tests * add test * add test * add test * happy path * test happy path * docs * stop server after * fix/lint import ordering * use older new platform apis * prettier * config => HttpConfig
peterschretlen
pushed a commit
to peterschretlen/kibana
that referenced
this pull request
Jul 23, 2019
peterschretlen
pushed a commit
to peterschretlen/kibana
that referenced
this pull request
Jul 23, 2019
peterschretlen
pushed a commit
to peterschretlen/kibana
that referenced
this pull request
Jul 23, 2019
peterschretlen
pushed a commit
that referenced
this pull request
Jul 24, 2019
peterschretlen
pushed a commit
that referenced
this pull request
Jul 24, 2019
peterschretlen
pushed a commit
that referenced
this pull request
Jul 24, 2019
|
@jbudz @peterschretlen it seems this has been reverted on 6.8 branch again. Is there plans to reintroduce this, otherwise I think we should remove the 6.8.2 label from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces two new kibana.yml configurations:
server.socketTimeout: default 2 minutes, close sockets after this amount of inactivityserver.keepAliveTimeout: default 2 minutes, close keepalive sockets after this amount of inactivityCloses #31549