-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] LayerControl read only mode #31318
Conversation
Pinging @elastic/kibana-gis |
This is a known issue that is getting addressed in EUI - elastic/eui#1571 and will go away with an EUI upgrade. The PR switches |
To test, just manually edit
isReadOnly mode to true
|
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. +1 on just managing this in the store as opposed to getting this setting from some static module function. it will keep it aligned with the other UI-state.
💚 Build Succeeded |
7.x backport blocked by #31550 |
* hide add layer button in read only mode * update TOCEntry for read only mode * make LayerTOC read only * default isReadOnly to false * remove action creator until its beig used
@nreese if a role has read only access to a space, is this the mode that will now be presented to them? |
And if so, would it close this in your opinion? #30313 |
👍 sounds good, thanks @nreese |
This PR adds
isReadOnly
mode to the ui store. When true,LayerControl
does not displayAdd layer
buttonThe reason for large number of changes is this PR starts to add jest snapshot tests for the LayerControl to verify isReadOnly flag does the above actions.