-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Add mappings for standalone archives and fix tests #31315
Merged
chrisronline
merged 2 commits into
elastic:master
from
chrisronline:monitoring/standalone_mappings
Feb 19, 2019
Merged
[Monitoring] Add mappings for standalone archives and fix tests #31315
chrisronline
merged 2 commits into
elastic:master
from
chrisronline:monitoring/standalone_mappings
Feb 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
added
review
v7.0.0
Team:Monitoring
Stack Monitoring team
v8.0.0
v7.2.0
v6.7.1
labels
Feb 15, 2019
Pinging @elastic/stack-monitoring |
💔 Build Failed |
💚 Build Succeeded |
ycombinator
approved these changes
Feb 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM. I didn't run the tests locally but good to merge as CI is green.
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Feb 19, 2019
…tic#31315) * Add mappings for standalone and fix tests * We are apparently mutating this and need to return a copy each time
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Feb 19, 2019
…tic#31315) * Add mappings for standalone and fix tests * We are apparently mutating this and need to return a copy each time
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Feb 19, 2019
…tic#31315) * Add mappings for standalone and fix tests * We are apparently mutating this and need to return a copy each time
chrisronline
added a commit
that referenced
this pull request
Feb 19, 2019
…) (#31470) * Add mappings for standalone and fix tests * We are apparently mutating this and need to return a copy each time
chrisronline
added a commit
that referenced
this pull request
Feb 19, 2019
…) (#31469) * Add mappings for standalone and fix tests * We are apparently mutating this and need to return a copy each time
chrisronline
added a commit
that referenced
this pull request
Feb 19, 2019
…) (#31468) * Add mappings for standalone and fix tests * We are apparently mutating this and need to return a copy each time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #30152
Resolves #31336
This PR addresses #31336, which explains both code changes.