Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Add mappings for standalone archives and fix tests #31315

Merged

Conversation

chrisronline
Copy link
Contributor

@chrisronline chrisronline commented Feb 15, 2019

Relates to #30152
Resolves #31336

This PR addresses #31336, which explains both code changes.

@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. I didn't run the tests locally but good to merge as CI is green.

@chrisronline chrisronline merged commit 3842984 into elastic:master Feb 19, 2019
@chrisronline chrisronline deleted the monitoring/standalone_mappings branch February 19, 2019 14:05
chrisronline added a commit to chrisronline/kibana that referenced this pull request Feb 19, 2019
…tic#31315)

* Add mappings for standalone and fix tests

* We are apparently mutating this and need to return a copy each time
chrisronline added a commit to chrisronline/kibana that referenced this pull request Feb 19, 2019
…tic#31315)

* Add mappings for standalone and fix tests

* We are apparently mutating this and need to return a copy each time
chrisronline added a commit to chrisronline/kibana that referenced this pull request Feb 19, 2019
…tic#31315)

* Add mappings for standalone and fix tests

* We are apparently mutating this and need to return a copy each time
chrisronline added a commit that referenced this pull request Feb 19, 2019
…) (#31470)

* Add mappings for standalone and fix tests

* We are apparently mutating this and need to return a copy each time
chrisronline added a commit that referenced this pull request Feb 19, 2019
…) (#31469)

* Add mappings for standalone and fix tests

* We are apparently mutating this and need to return a copy each time
@chrisronline
Copy link
Contributor Author

chrisronline commented Feb 19, 2019

Backport:

6.7: 46538f4
7.0: 6da397b
7.x: 4400333

chrisronline added a commit that referenced this pull request Feb 19, 2019
…) (#31468)

* Add mappings for standalone and fix tests

* We are apparently mutating this and need to return a copy each time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants