Move index pattern selector into index pattern header in discover #3060
+39
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| controller: function ($scope) { | ||
| controller: function ($scope, $route) { | ||
| $scope.setIndexPattern = function (indexPattern) { | ||
| $scope.state.index = indexPattern; |
There was a problem hiding this comment.
This relies on $scope.state being initialized in a parent scope, which, in practice, should always be the case. However, I sort of don't like external dependencies like this. I could just as easily inject AppState, and initialize $scope.state = new AppState(); at the top of the controller function. Would that be a better alternative?
There was a problem hiding this comment.
This is only 1 of 2 directives where the state is passed in, the other bring the filter bar. There, it makes sense as you don't want to have to re-render the whole app to change the filters. Here, the only time you use state is when you re-rendering anyway, so I think it makes sense not to pass it in.
|
2 UI things:
|
|
🎳 LGTM |
w33ble
added a commit
that referenced
this pull request
Feb 25, 2015
Move index pattern selector into index pattern header in discover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the index pattern selector in discover to the sidebar, where we added an index pattern title recently. It also removes the code associated with the older selector.
Closes #3024.