Move more directories into src/legacy #30435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
epixa
added
Feature:Plugins
Team:Core
|
Pinging @elastic/kibana-platform |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@spalger This is ready for review when you get a chance tomorrow. |
epixa
commented
Feb 10, 2019
| @@ -91,8 +91,7 @@ export class Build { | |||
| sourceMap: true, | |||
| sourceMapEmbed: true, | |||
| includePaths: [ | |||
| resolve(__dirname, '../..'), | |||
There was a problem hiding this comment.
This is really the change in this PR that isn't strictly just adjusting paths. The existing sass implementation for plugins allowed importing from anywhere inside src. I spoke to @tylersmalley about this and we agreed to just let plugin sass import relative to root rather than update this to import from within src/legacy.
There were a couple reasons for this:
- We can't statically analyze sass, so any sort of bulk updates to paths will need to be done through find/replace. Something more specific like
src/legacy/uiis much easier to grep for than justui. - If you don't know exactly where to look, finding this path configuration is challenging since it's just string-based relative paths.
- Why not treat paths a little less magically?
We both also agreed that node_modules should probably be removed as well so folks would need to import those relative root as well, but that felt out of scope of this PR since it wasn't already touching any of those imports.
mikecote
approved these changes
Feb 11, 2019
This commit accompanies the four that precede it. Rather than squash them altogether, the four previous commits all do nothing except move files to help avoid conflicts.
epixa
added a commit
that referenced
this pull request
Feb 11, 2019
Moves the following directories into src/legacy: src/deprecation -> src/legacy/deprecation src/ui -> src/legacy/ui src/server -> src/legacy/server src/plugin_discovery -> src/legacy/plugin_discovery src/utils -> src/legacy/utils
epixa
added a commit
that referenced
this pull request
Feb 11, 2019
Moves the following directories into src/legacy: src/deprecation -> src/legacy/deprecation src/ui -> src/legacy/ui src/server -> src/legacy/server src/plugin_discovery -> src/legacy/plugin_discovery src/utils -> src/legacy/utils
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are six commits here, and they will be merged as-is rather than squashed first.
The first five commits perform the following moves:
The final commit cleans up path references across the project into and out of those locations.
This is to support the new platform migration effort, and the target structure as a whole is described in #12466.
Note, I might backport this to 6.7.0. It depends how seamless that turns out to be.