Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upgrade] Localize reindexing flyout in Upgrade Assistant #30432

Merged
merged 5 commits into from
Feb 19, 2019
Merged

[upgrade] Localize reindexing flyout in Upgrade Assistant #30432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
24a21cc
Localize reindexing flyout
joshdover Feb 7, 2019
f4742ff
Merge remote-tracking branch 'upstream/master' into upgrade-assistant…
joshdover Feb 14, 2019
a424b0a
Review comments
joshdover Feb 14, 2019
8acc56f
Test fix
joshdover Feb 15, 2019
913f00f
Adjust copy for clarity
joshdover Feb 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 37 additions & 6 deletions .../plugins/upgrade_assistant/public/components/tabs/checkup/deprecations/reindex/button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import React, { Fragment, ReactNode } from 'react';
import { Subscription } from 'rxjs';

import { EuiButton, EuiLoadingSpinner } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n/react';
import { kfetch } from 'ui/kfetch';
import { ReindexStatus, UIReindexOption } from '../../../../../../common/types';
import { LoadingState } from '../../../../types';
Expand Down Expand Up @@ -63,11 +64,21 @@ export class ReindexButton extends React.Component<ReindexButtonProps, ReindexBu
const { flyoutVisible, reindexState } = this.state;

const buttonProps: any = { size: 's', onClick: this.showFlyout };
let buttonContent: ReactNode = 'Reindex';
let buttonContent: ReactNode = (
<FormattedMessage
id="xpack.upgradeAssistant.checkupTab.reindexing.reindexButton.reindexLabel"
defaultMessage="Reindex"
/>
);

if (reindexState.loadingState === LoadingState.Loading) {
buttonProps.disabled = true;
buttonContent = 'Loading…';
buttonContent = (
<FormattedMessage
id="xpack.upgradeAssistant.checkupTab.reindexing.reindexButton.loadingLabel"
defaultMessage="Loading…"
/>
);
} else {
switch (reindexState.status) {
case ReindexStatus.inProgress:
Expand All @@ -81,24 +92,44 @@ export class ReindexButton extends React.Component<ReindexButtonProps, ReindexBu
buttonProps.color = 'secondary';
buttonProps.iconSide = 'left';
buttonProps.iconType = 'check';
buttonContent = 'Done';
buttonContent = (
<FormattedMessage
id="xpack.upgradeAssistant.checkupTab.reindexing.reindexButton.doneLabel"
defaultMessage="Done"
/>
);
break;
case ReindexStatus.failed:
buttonProps.color = 'danger';
buttonProps.iconSide = 'left';
buttonProps.iconType = 'cross';
buttonContent = 'Failed';
buttonContent = (
<FormattedMessage
id="xpack.upgradeAssistant.checkupTab.reindexing.reindexButton.failedLabel"
defaultMessage="Failed"
/>
);
break;
case ReindexStatus.paused:
buttonProps.color = 'warning';
buttonProps.iconSide = 'left';
buttonProps.iconType = 'pause';
buttonContent = 'Paused';
buttonContent = (
<FormattedMessage
id="xpack.upgradeAssistant.checkupTab.reindexing.reindexButton.pausedLabel"
defaultMessage="Paused"
/>
);
case ReindexStatus.cancelled:
buttonProps.color = 'danger';
buttonProps.iconSide = 'left';
buttonProps.iconType = 'cross';
buttonContent = 'Cancelled';
buttonContent = (
<FormattedMessage
id="xpack.upgradeAssistant.checkupTab.reindexing.reindexButton.cancelledLabel"
defaultMessage="Cancelled"
/>
);
break;
}
}
Expand Down
40 changes: 34 additions & 6 deletions ...nents/tabs/checkup/deprecations/reindex/flyout/__snapshots__/checklist_step.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,29 @@ exports[`ChecklistFlyout renders 1`] = `
color="warning"
iconType="alert"
size="m"
title="Index is unable to ingest, update, or delete documents while reindexing"
title={
<FormattedMessage
defaultMessage="Index is unable to ingest, update, or delete documents while reindexing"
id="xpack.upgradeAssistant.checkupTab.reindexing.flyout.checklistStep.readonlyCallout.calloutTitle"
values={Object {}}
/>
}
>
<p>
If you can’t stop document updates or need to reindex into a new cluster, consider using a different upgrade strategy.
<FormattedMessage
defaultMessage="If you can’t stop document updates or need to reindex into a new cluster,
consider using a different upgrade strategy."
id="xpack.upgradeAssistant.checkupTab.reindexing.flyout.checklistStep.readonlyCallout.cantStopDetail"
values={Object {}}
/>
</p>
<p>
Reindexing will continue in the background, but if Kibana shuts down or restarts you will need to return to this page to resume reindexing.
<FormattedMessage
defaultMessage="Reindexing will continue in the background, but if Kibana shuts down or restarts you will
need to return to this page to resume reindexing."
id="xpack.upgradeAssistant.checkupTab.reindexing.flyout.checklistStep.readonlyCallout.backgroundResumeDetail"
values={Object {}}
/>
</p>
</EuiCallOut>
<EuiSpacer
Expand All @@ -24,7 +40,11 @@ exports[`ChecklistFlyout renders 1`] = `
textTransform="none"
>
<h3>
Reindexing process
<FormattedMessage
defaultMessage="Reindexing process"
id="xpack.upgradeAssistant.checkupTab.reindexing.flyout.checklistStep.reindexingChecklistTitle"
values={Object {}}
/>
</h3>
</EuiTitle>
<Component
Expand Down Expand Up @@ -66,7 +86,11 @@ exports[`ChecklistFlyout renders 1`] = `
onClick={[MockFunction]}
type="button"
>
Close
<FormattedMessage
defaultMessage="Close"
id="xpack.upgradeAssistant.checkupTab.reindexing.flyout.checklistStep.closeButtonLabel"
values={Object {}}
/>
</EuiButtonEmpty>
</EuiFlexItem>
<EuiFlexItem
Expand All @@ -82,7 +106,11 @@ exports[`ChecklistFlyout renders 1`] = `
onClick={[MockFunction]}
type="button"
>
Run reindex
<FormattedMessage
defaultMessage="Run reindex"
id="xpack.upgradeAssistant.checkupTab.reindexing.flyout.checklistStep.reindexButton.runReindexLabel"
values={Object {}}
/>
</EuiButton>
</EuiFlexItem>
</EuiFlexGroup>
Expand Down
Loading