Don't trigger autorefresh when autofetch false #30405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
bug
|
Pinging @elastic/kibana-app |
timroes
commented
Feb 7, 2019
| @@ -127,8 +127,6 @@ export class EmbeddedVisualizeHandler { | |||
| forceFetch: false, | |||
| }; | |||
|
|
|||
| this.autoFetch = !(autoFetch === false); | |||
There was a problem hiding this comment.
I used a default value up, to make that a bit better readable.
💚 Build Succeeded |
lukeelmers
approved these changes
Feb 7, 2019
There was a problem hiding this comment.
This LGTM. Could use some tests, but as discussed, we will cover that in #30422.
Tested locally Chrome OSX, compared to master, verified fixed 🚀
|
Merging/backporting now so I can update #30167 accordingly. |
lukeelmers
pushed a commit
to lukeelmers/kibana
that referenced
this pull request
Feb 7, 2019
lukeelmers
pushed a commit
to lukeelmers/kibana
that referenced
this pull request
Feb 7, 2019
This was referenced Feb 7, 2019
lukeelmers
pushed a commit
to lukeelmers/kibana
that referenced
this pull request
Feb 7, 2019
lukeelmers
added a commit
that referenced
this pull request
Feb 7, 2019
lukeelmers
added a commit
that referenced
this pull request
Feb 8, 2019
lukeelmers
added a commit
that referenced
this pull request
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #30347
Discover used the
visualize_loaderbut setautoFetch: false, to prevent it auto fetching the data. That flag usually mean you want to manually callrender, etc. so I extended that flag to also prevent theautoRefreshFetchof the timepicker to trigger a fetch/render, since that failed on Discover since there was no valid vis configuration to actually fetch the data, since it's passed in directly into therendermethod by the Discover app.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately