[ML] Removing old angular based start datafeed modal #30392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
jgowdyelastic
force-pushed
the
removing-old-and-broken-start-datafeed-modal
branch
2 times, most recently
from
1ee23df to
0ec1155
Compare
💚 Build Succeeded |
💚 Build Succeeded |
💔 Build Failed |
jgowdyelastic
force-pushed
the
removing-old-and-broken-start-datafeed-modal
branch
from
c006b4b to
9263a8b
Compare
jgowdyelastic
requested review from
peteharverson,
walterra and
alvarezmelissa87
💚 Build Succeeded |
jgowdyelastic
added
review
v7.0.0
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui |
jgowdyelastic
changed the title
walterra
approved these changes
Feb 8, 2019
💚 Build Succeeded |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Feb 8, 2019
* [ML] Removing old and broken start datafeed modal * fixing typos * removing need to load job from server * small refactor * adding comments * removing unnecessary async/await
lukeelmers
pushed a commit
to lukeelmers/kibana
that referenced
this pull request
Feb 8, 2019
* [ML] Removing old and broken start datafeed modal * fixing typos * removing need to load job from server * small refactor * adding comments * removing unnecessary async/await
jgowdyelastic
added a commit
that referenced
this pull request
Feb 11, 2019
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Feb 11, 2019
* [ML] Removing old and broken start datafeed modal * fixing typos * removing need to load job from server * small refactor * adding comments * removing unnecessary async/await
jgowdyelastic
added a commit
that referenced
this pull request
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the old angular based start datafeed modal used when creating a job in the advanced wizard with the new react based one.
Uses
mlJobService.currentJobto pass the newly created job object back to the job management page. Similar to how we pass a job to the advanced wizard when cloning.Completely removes the angular based 'mlDatafeedService
andMlJobTimepickerModal`.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately