Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task Manager] remove [DOC_TYPE] from index template body #30261

Merged

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Feb 6, 2019

Summary

Starting Kibana with Task Manager enabled broke recently due to incompatibility with ES in the way it was trying to put the index template. The ES change seems to be: elastic/elasticsearch#38270

This keeps the type name in the mapping to make maintaining 6.x with backports easier.

This fixes an error when starting Kibana:

server    log   [16:32:11.715] [info][task_manager] Installing .kibana_task_manager index template version: 8000099.
server    log   [16:32:11.727] [warning][task_manager] [illegal_argument_exception] The mapping definition cannot be nested under a type [_doc] unless include_type_name is set to true.

@jpountz
Copy link

jpountz commented Feb 6, 2019

Ideally on 7.0+ we would instead remove [DOC_TYPE]: { a couple lines below. This fix "works" but is deprecated since we are moving towards removing the notion of types.
This is the right approach on 6.7 however.

@tsullivan
Copy link
Member Author

Ideally on 7.0+ we would instead remove [DOC_TYPE]: { a couple lines below. This fix "works" but is deprecated since we are moving towards removing the notion of types.
This is the right approach on 6.7 however.

That's fine. We can do a different fix for 7.0+ and 6.7. Updates coming.
cc @tylersmalley

@tsullivan
Copy link
Member Author

Just the 1st commit will be backported to 6.7

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@tsullivan
Copy link
Member Author

Test failures are known/unrelated.

Error: Unable to download elasticsearch snapshot: Not Found

Kibana test server isn't able to download an 8.0.0 snapshot for Elasticsearch, as that version hasn't been published yet

@tsullivan tsullivan merged commit 3bca5c0 into elastic:master Feb 6, 2019
@tsullivan tsullivan deleted the fix/taskmanager/include_type_name branch February 6, 2019 20:00
tsullivan added a commit to tsullivan/kibana that referenced this pull request Feb 6, 2019
…stic#30261)

* [Task Manager] Provide "include_type_name: true" in put template

* fix for 7.0+
tsullivan added a commit to tsullivan/kibana that referenced this pull request Feb 6, 2019
…stic#30261)

* [Task Manager] Provide "include_type_name: true" in put template

* fix for 7.0+
tsullivan added a commit to tsullivan/kibana that referenced this pull request Feb 6, 2019
…stic#30261)

* [Task Manager] Provide "include_type_name: true" in put template

* fix for 7.0+
tsullivan added a commit that referenced this pull request Feb 7, 2019
) (#30303)

* [Task Manager] Provide "include_type_name: true" in put template

* fix for 7.0+
tsullivan added a commit that referenced this pull request Feb 7, 2019
) (#30302)

* [Task Manager] Provide "include_type_name: true" in put template

* fix for 7.0+
tsullivan added a commit that referenced this pull request Feb 7, 2019
#30261) (#30304)

* [Task Manager] Provide "include_type_name: true" in put template (#30261)

* [Task Manager] Provide "include_type_name: true" in put template

* fix for 7.0+

* fix for 6.7
@tsullivan tsullivan changed the title [Task Manager] Provide "include_type_name: true" in put template [Task Manager] remove [DOC_TYPE] from index template body Feb 7, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants