[Canvas] Only runs duplicate workpad load once #30150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqliu1
added
review
v7.0.0
Team:Presentation
|
Pinging @elastic/kibana-canvas |
cqliu1
changed the title
💚 Build Succeeded |
cqliu1
force-pushed
the
fix/write-permission-check
branch
2 times, most recently
from
c8f1352 to
49f5c86
Compare
💔 Build Failed |
💔 Build Failed |
monfera
approved these changes
Feb 7, 2019
|
retest |
💔 Build Failed |
cqliu1
force-pushed
the
fix/write-permission-check
branch
from
49f5c86 to
388a72c
Compare
💔 Build Failed |
cqliu1
force-pushed
the
fix/write-permission-check
branch
from
388a72c to
dd5eabe
Compare
💚 Build Succeeded |
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Feb 11, 2019
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Feb 11, 2019
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Feb 11, 2019
cqliu1
added a commit
that referenced
this pull request
Feb 11, 2019
cqliu1
added a commit
that referenced
this pull request
Feb 11, 2019
cqliu1
added a commit
that referenced
this pull request
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #24385.
This adds a new property
isFirstLoadto transient state to keep track if a user has loaded a workpad, and now we only test the user's write permissions once instead of on every workpad load. This is just an interim solution until granular app privileges are available (#20277).