[Reporting] refactor routes files and helpers #30111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
joelgriffith
reviewed
Feb 5, 2019
x-pack/plugins/reporting/export_types/csv/server/lib/generate_csv.js
Outdated
Show resolved
Hide resolved
|
This is a nice cleanup... what do you think about doing TS for some of this (at least the newer modules)? |
|
@joelgriffith sure, I can put some of the changes in as TS. I'm hunting down a failing unit test, and then I'll pick that up |
tsullivan
commented
Feb 6, 2019
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| import _ from 'lodash'; | |||
|
|
|||
| export function createFlattenHit(fields, metaFields, conflictedTypesFields) { | |||
| export function createFlattenHit(fields, metaFields, conflictedTypesFields = []) { | |||
There was a problem hiding this comment.
Whoops, looks like there was a unit test expecting this to cause a failure
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
retest |
💔 Build Failed |
tsullivan
added
review
v8.0.0
(Deprecated) Feature:Reporting
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
| @@ -7,8 +7,7 @@ | |||
| import { resolve } from 'path'; | |||
| import { UI_SETTINGS_CUSTOM_PDF_LOGO } from './common/constants'; | |||
| import { mirrorPluginStatus } from '../../server/lib/mirror_plugin_status'; | |||
There was a problem hiding this comment.
Nice consolidation here
joelgriffith
approved these changes
Feb 12, 2019
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Feb 12, 2019
* remove unused file * refactor routes files and helpers * default empty array for conflictedTypesFields * minor prettier * remove some unrelated diff * some typescript conversions * more typescripts * more typscript * jobtype is a string * revert some logic change * set payload.headers to undefined + not mutate * fix jest import
This was referenced Feb 12, 2019
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Feb 12, 2019
* remove unused file * refactor routes files and helpers * default empty array for conflictedTypesFields * minor prettier * remove some unrelated diff * some typescript conversions * more typescripts * more typscript * jobtype is a string * revert some logic change * set payload.headers to undefined + not mutate * fix jest import
tsullivan
added a commit
that referenced
this pull request
Feb 13, 2019
* remove unused file * refactor routes files and helpers * default empty array for conflictedTypesFields * minor prettier * remove some unrelated diff * some typescript conversions * more typescripts * more typscript * jobtype is a string * revert some logic change * set payload.headers to undefined + not mutate * fix jest import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server/routesget_absolute_timeWIP: Hold off until #29977 is merged