-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K7 Discover app cleanup #30037
Merged
Merged
K7 Discover app cleanup #30037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
added
Team:Platform-Design
Team Label for Kibana Design Team. Support the Analyze group of plugins.
Feature:Discover
Discover Application
v7.0.0
v6.7.0
labels
Feb 5, 2019
Pinging @elastic/kibana-design |
💔 Build Failed |
💔 Build Failed |
retest |
💔 Build Failed |
💚 Build Succeeded |
Yay. With a little over an hour to spare :) @cchaos if you have time in the morning. feel free to do a quick review. I also fixed a dark mode issue with the kibana loader. |
cchaos
approved these changes
Feb 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
snide
added a commit
to snide/kibana
that referenced
this pull request
Feb 6, 2019
Does some design cleanup in the discover application.
snide
added a commit
to snide/kibana
that referenced
this pull request
Feb 6, 2019
Does some design cleanup in the discover application.
snide
added a commit
that referenced
this pull request
Feb 6, 2019
snide
added a commit
that referenced
this pull request
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Discover
Discover Application
Team:Platform-Design
Team Label for Kibana Design Team. Support the Analyze group of plugins.
v6.7.0
v7.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cc @cchaos @Bargs @lukasolson for awareness
Some quickie cleanup for the discover app
TODO
Doc table rows decluttered
I removed all the repetitive icons and bordering. Now the action buttons show up on hover. I also did an angular
.euiTab
fakeout because those bootstrap tabs were hideous.Cleanup of filter bar and index selector
Just a bunch of minor cleanup to fix the popover dropdowns, spacing and sizing of these elements.
Sidebar cleanup
Cleaned up the sidebar to be less aggressive. Will likely do a similar cleanup to repetitive icons here.
Fixed obvious dark mode breaks
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers