Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K7 Discover app cleanup #30037

Merged
merged 15 commits into from
Feb 6, 2019
Merged

K7 Discover app cleanup #30037

merged 15 commits into from
Feb 6, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented Feb 5, 2019

Summary

cc @cchaos @Bargs @lukasolson for awareness

Some quickie cleanup for the discover app

TODO

  • fix some accessibility stuff caused by the hover states
  • I'll also need to do cleanup of the surround document pages
  • hunt down an errant horizontal scrollbar

Doc table rows decluttered

I removed all the repetitive icons and bordering. Now the action buttons show up on hover. I also did an angular .euiTab fakeout because those bootstrap tabs were hideous.

Cleanup of filter bar and index selector

Just a bunch of minor cleanup to fix the popover dropdowns, spacing and sizing of these elements.

Sidebar cleanup

Cleaned up the sidebar to be less aggressive. Will likely do a similar cleanup to repetitive icons here.

image

Fixed obvious dark mode breaks

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@snide snide added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Feature:Discover Discover Application v7.0.0 v6.7.0 labels Feb 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design

@snide snide requested a review from a team as a code owner February 5, 2019 06:08
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor Author

snide commented Feb 6, 2019

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@snide
Copy link
Contributor Author

snide commented Feb 6, 2019

Yay. With a little over an hour to spare :)

@cchaos if you have time in the morning. feel free to do a quick review. I also fixed a dark mode issue with the kibana loader.

@snide snide changed the title [WIP] K7 Discover app cleanup K7 Discover app cleanup Feb 6, 2019
@snide snide requested review from cchaos and ryankeairns February 6, 2019 16:55
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@snide snide merged commit 662a5ab into elastic:master Feb 6, 2019
@snide snide deleted the cleanup/discover branch February 6, 2019 18:12
snide added a commit to snide/kibana that referenced this pull request Feb 6, 2019
Does some design cleanup in the discover application.
snide added a commit to snide/kibana that referenced this pull request Feb 6, 2019
Does some design cleanup in the discover application.
snide added a commit that referenced this pull request Feb 6, 2019
Does some design cleanup in the discover application.
snide added a commit that referenced this pull request Feb 13, 2019
Does some design cleanup in the discover application.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.7.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants