Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.7][Maps]Remove dark mode and default to kuery #30007

Merged
merged 2 commits into from
Feb 5, 2019

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Feb 4, 2019

application specific theming is removed in 7.0. No point providing a feature that we know will get removed in the next version. This PR removes dark theme from 6.7 (it is already removed in 7.0).

This PR also sets the default query language to kuery. In 7.0, the default will be set to kuery and we want that behavior in 6.7

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v6.7.0 labels Feb 4, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

@nreese nreese requested a review from thomasneirynck February 4, 2019 22:16
@trevan
Copy link
Contributor

trevan commented Feb 4, 2019

This sounds like a big change for a point release.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@nreese
Copy link
Contributor Author

nreese commented Feb 4, 2019

This sounds like a big change for a point release.

@trevan This change is only for the maps application which has yet to be released. 6.7 is the maps application debut release. This will not effect any other application like Dashboard

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@nreese nreese merged commit db38e66 into elastic:6.x Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v6.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants