Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSS-Telemetry] Make the plugin have the right config prefix #30005

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

tsullivan
Copy link
Member

Summary

#28793 added a new oss_telemetry plugin in x-pack. I realized after the fact the config prefix for the plugin should be xpack.oss_telemetry instead of just the default.

The way to disable the plugin:

Before

oss_telemetry.enabled: false

After

xpack.oss_telemetry.enabled: false

@tsullivan tsullivan added review v7.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.7.0 labels Feb 4, 2019
@tsullivan tsullivan requested review from epixa and njd5475 February 4, 2019 22:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@epixa epixa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsullivan tsullivan merged commit 5fea0c7 into elastic:master Feb 5, 2019
@tsullivan tsullivan deleted the telemetry/xpack-prefix branch February 5, 2019 20:33
tsullivan added a commit to tsullivan/kibana that referenced this pull request Feb 5, 2019
@tsullivan
Copy link
Member Author

6.x/6.7: #30132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.7.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants