Typings for saved object client #29951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mikecote |
timroes
changed the title
|
Jenkins, test this |
timroes
added
Team:Core
|
Pinging @elastic/kibana-platform |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
1 task
weltenwort
requested changes
Feb 6, 2019
There was a problem hiding this comment.
Thanks for typing a critical piece of the Kibana infrastructure 🎉
Since I don't know this code very well I focused mainly on internal consistency. All in all it seems to work, but I left some inline comments below regarding imports from server-side code, some apparent left-overs from development and the usage of @ts-ignore directives.
💚 Build Succeeded |
💔 Build Failed |
weltenwort
approved these changes
Feb 6, 2019
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
Jenkins, test this - flaky failure on dashboard embeddable test |
💚 Build Succeeded |
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Feb 7, 2019
* WIP typings for saved object client * Move more files to TS * type saved objects client * clean up typings for saved object client * tie typings form server and client for saved objects together * add missing html import typing to x-pack * Add missing buildSourcePatterns * Removed accidental comma * add typings for saved_object_client tests and fix test cases * duplicate case_conversion helpers for the moment * Address PR review * Fix some documentation * Replace ts-ignore by any imports * Remove expect.js from test * Add more typings to prevent CI failure
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Feb 7, 2019
* WIP typings for saved object client * Move more files to TS * type saved objects client * clean up typings for saved object client * tie typings form server and client for saved objects together * add missing html import typing to x-pack * Add missing buildSourcePatterns * Removed accidental comma * add typings for saved_object_client tests and fix test cases * duplicate case_conversion helpers for the moment * Address PR review * Fix some documentation * Replace ts-ignore by any imports * Remove expect.js from test * Add more typings to prevent CI failure
timroes
added a commit
that referenced
this pull request
Feb 7, 2019
* WIP typings for saved object client * Move more files to TS * type saved objects client * clean up typings for saved object client * tie typings form server and client for saved objects together * add missing html import typing to x-pack * Add missing buildSourcePatterns * Removed accidental comma * add typings for saved_object_client tests and fix test cases * duplicate case_conversion helpers for the moment * Address PR review * Fix some documentation * Replace ts-ignore by any imports * Remove expect.js from test * Add more typings to prevent CI failure
timroes
added a commit
that referenced
this pull request
Feb 7, 2019
* WIP typings for saved object client * Move more files to TS * type saved objects client * clean up typings for saved object client * tie typings form server and client for saved objects together * add missing html import typing to x-pack * Add missing buildSourcePatterns * Removed accidental comma * add typings for saved_object_client tests and fix test cases * duplicate case_conversion helpers for the moment * Address PR review * Fix some documentation * Replace ts-ignore by any imports * Remove expect.js from test * Add more typings to prevent CI failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add typings for the saved object client in the browser. @mikecote since that PR began before the reference changes, I had to merge them in, so it would be could if you could validate, that nothing broke there due to this PR.
For QA: This PR should not change any behavior, since it's a pure conversion from JavaScript to TypeScript.
This need to go to 7.0 still, since it's a requirement for TypeScriptification of the SavedObjectFinder, which is a requirement for the remaining EUIfication work, that should still go into 7.0.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately