Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Update browser title to stack monitoring #29638

Merged
merged 1 commit into from
Jan 30, 2019
Merged

[Monitoring] Update browser title to stack monitoring #29638

merged 1 commit into from
Jan 30, 2019

Conversation

chrisronline
Copy link
Contributor

Fixes #29555

Simple update to ensure the browser title also says Stack Monitoring

@chrisronline chrisronline self-assigned this Jan 30, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring

ycombinator
ycombinator approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally LGTM — Checked out and ran PR and I see "Stack Monitoring" in the page titles now.

Code changes were overwhelming but also LGTM 😅

I don't see a 6.7.0 label on the PR. We should backport this to 6.x too, yes?

@chrisronline
Copy link
Contributor Author

chrisronline commented Jan 30, 2019 •
edited
Loading

The left nav change was only in 7.0: #28102.

Should they both go into 6.7?

@ycombinator
Copy link
Contributor

Ah good point, thanks. Only 7.0 it is!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@chrisronline chrisronline merged commit 6eeccb8 into elastic:master Jan 30, 2019
@chrisronline chrisronline deleted the monitoring/browser_title_update branch January 30, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees

@chrisronline chrisronline

Labels
review Team:Monitoring Stack Monitoring team v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisronline @elasticmachine @ycombinator