Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chrome/breadcrumbs] add push/filter methods #29566

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jan 30, 2019

Adds two methods to the chrome.breadcrumbs api with the goal of reducing the state management necessary in integrations like https://github.com/elastic/kibana/blob/master/x-pack/plugins/beats_management/public/components/navigation/breadcrumb/provider.tsx.

@spalger spalger added review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 v6.7.0 labels Jan 30, 2019
@spalger spalger requested a review from mikecote January 30, 2019 02:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecote mikecote added review and removed review labels Jan 30, 2019
@spalger spalger merged commit 85d8f38 into elastic:master Jan 30, 2019
spalger pushed a commit to spalger/kibana that referenced this pull request Jan 30, 2019
spalger pushed a commit that referenced this pull request Jan 30, 2019
Backports the following commits to 6.x:
 - [chrome/breadcrumbs] add push/filter methods  (#29566)
@spalger
Copy link
Contributor Author

spalger commented Jan 30, 2019

6.x/6.7: 7d3f295

@spalger spalger deleted the implement/breadcrumbs-add-filter branch January 30, 2019 18:51
@spalger spalger added the non-issue Indicates to automation that a pull request should not appear in the release notes label Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-issue Indicates to automation that a pull request should not appear in the release notes review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.7.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants